Skip to content

Move s3/testing_utils.go#45362

Merged
lucasmrod merged 4 commits into
mainfrom
remove-more-testing-utils-from-production-binaries-round-3
May 13, 2026
Merged

Move s3/testing_utils.go#45362
lucasmrod merged 4 commits into
mainfrom
remove-more-testing-utils-from-production-binaries-round-3

Conversation

@lucasmrod
Copy link
Copy Markdown
Member

@lucasmrod lucasmrod commented May 13, 2026

Resolves #45220 (one of many PRs)

Testing

  • QA'd all new/changed functionality manually.

Smoke tested upload/download of software installers, upload/download of bootstrap packages.

@lucasmrod lucasmrod requested a review from a team as a code owner May 13, 2026 13:07
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 77.41935% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.71%. Comparing base (cb32085) to head (404a302).

Files with missing lines Patch % Lines
server/datastore/s3/s3test/s3test.go 80.00% 5 Missing and 3 partials ⚠️
server/datastore/s3/s3.go 72.72% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@                                      Coverage Diff                                       @@
##           remove-more-testing-utils-from-production-binaries-round-2   #45362      +/-   ##
==============================================================================================
- Coverage                                                       66.72%   66.71%   -0.01%     
==============================================================================================
  Files                                                            2731     2731              
  Lines                                                          218495   218487       -8     
  Branches                                                        10696    10696              
==============================================================================================
- Hits                                                           145786   145766      -20     
- Misses                                                          59500    59506       +6     
- Partials                                                        13209    13215       +6     
Flag Coverage Δ
backend 68.55% <77.41%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sgress454
sgress454 previously approved these changes May 13, 2026
Base automatically changed from remove-more-testing-utils-from-production-binaries-round-2 to main May 13, 2026 16:57
@lucasmrod lucasmrod dismissed sgress454’s stale review May 13, 2026 16:57

The base branch was changed.

@lucasmrod lucasmrod requested a review from sgress454 May 13, 2026 16:58
@lucasmrod lucasmrod merged commit 33ebf28 into main May 13, 2026
48 checks passed
@lucasmrod lucasmrod deleted the remove-more-testing-utils-from-production-binaries-round-3 branch May 13, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Go's testing package from Fleet's production binary

2 participants