Skip website/config/custom.js in Trivy secret scan#45621
Conversation
The file contains commented-out Stripe test-mode example placeholders that match Trivy's secret regex and fail every push to main that touches a .tf file.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
This PR updates the Trivy workflow to avoid false-positive secret scan failures from documented Stripe test placeholders in the website development config.
Changes:
- Adds
website/config/custom.jsto Trivy’sskip-fileslist. - Documents why the file is skipped alongside existing local-test key exclusions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request modifies the Trivy security scanning workflow in Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
website/config/custom.jscontains commented-out Stripe test-mode placeholders (pk_test_.../sk_test_...) shown to developers as example billing config.mainthat touches a.tffile (e.g. the v4.85.0 release commit) trips the scan and fails CI: https://github.com/fleetdm/fleet/actions/runs/25920033570/job/76186369286skip-filesblock in.github/workflows/trivy-scan.yml, matching the pattern used for the demo/test TLS keys already listed there.Test plan
mainthat touches a.tffile does not fail the Trivy scan.Summary by CodeRabbit