Grayw guides update managinggooglechrome#46995
Conversation
Add an example ADMX file for Google Chrome management
Add an example profile for enrolling Chrome to the enterprise console
Improve layout and instructions
Minor edits
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Lost in the diff? Review this PR in Change Stack to follow the change map from intent to exact ranges. WalkthroughThis PR introduces a Windows configuration profile in XML format that enables Chrome cloud management enrollment through Microsoft MDM policies. The profile sets the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/solutions/windows/configuration-profiles/enroll` Google Chrome to
enterprise console.xml:
- Line 7: The CloudManagementEnrollmentToken value currently contains a
UUID-like example that can be accidentally copied and break enrollment; update
the <Data> element so the CloudManagementEnrollmentToken attribute uses an
explicit placeholder (e.g., "REPLACE_WITH_ENROLLMENT_TOKEN") or a clearly marked
example UUID plus "replace this" text; locate the Data tag containing data
id="CloudManagementEnrollmentToken" and change its value attribute to the
placeholder text to prevent silent copy/paste failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 916a42e1-89da-4125-ac63-e6843eb79097
⛔ Files ignored due to path filters (1)
articles/managing-chrome-with-fleet.mdis excluded by!**/*.md
📒 Files selected for processing (2)
docs/solutions/windows/configuration-profiles/admx Google Chrome.xmldocs/solutions/windows/configuration-profiles/enroll Google Chrome to enterprise console.xml
| <LocURI>./Device/Vendor/MSFT/Policy/Config/chrome~Policy~googlechrome/CloudManagementEnrollmentToken</LocURI> | ||
| </Target> | ||
| <Meta><Format xmlns="syncml:metinf">chr</Format></Meta> | ||
| <Data><enabled/><data id="CloudManagementEnrollmentToken" value="xxxxxxx-xxxx-43d3-b227-689c148ec054"/></Data> |
There was a problem hiding this comment.
Use an explicit placeholder token format to avoid copy/paste enrollment failures.
Line 7 currently shows a UUID-like value with an invalid shape (7-4-4-4-12), which is easy to copy as-is and silently break Chrome enrollment. Prefer a clearly named placeholder (or a valid UUID example with a “replace this” note).
Suggested doc-safe fix
- <Data><enabled/><data id="CloudManagementEnrollmentToken" value="xxxxxxx-xxxx-43d3-b227-689c148ec054"/></Data>
+ <Data><enabled/><data id="CloudManagementEnrollmentToken" value="YOUR_CLOUD_MANAGEMENT_ENROLLMENT_TOKEN_UUID"/></Data>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <Data><enabled/><data id="CloudManagementEnrollmentToken" value="xxxxxxx-xxxx-43d3-b227-689c148ec054"/></Data> | |
| <Data><enabled/><data id="CloudManagementEnrollmentToken" value="YOUR_CLOUD_MANAGEMENT_ENROLLMENT_TOKEN_UUID"/></Data> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/solutions/windows/configuration-profiles/enroll` Google Chrome to
enterprise console.xml at line 7, The CloudManagementEnrollmentToken value
currently contains a UUID-like example that can be accidentally copied and break
enrollment; update the <Data> element so the CloudManagementEnrollmentToken
attribute uses an explicit placeholder (e.g., "REPLACE_WITH_ENROLLMENT_TOKEN")
or a clearly marked example UUID plus "replace this" text; locate the Data tag
containing data id="CloudManagementEnrollmentToken" and change its value
attribute to the placeholder text to prevent silent copy/paste failures.
Related issue: Resolves #46637
Summary by CodeRabbit
Release Notes