Skip to content

Grayw guides update managinggooglechrome#46995

Open
GrayW wants to merge 4 commits into
mainfrom
grayw-guides-update-managinggooglechrome
Open

Grayw guides update managinggooglechrome#46995
GrayW wants to merge 4 commits into
mainfrom
grayw-guides-update-managinggooglechrome

Conversation

@GrayW
Copy link
Copy Markdown
Member

@GrayW GrayW commented Jun 6, 2026

Related issue: Resolves #46637

  • Updated the wording and flow of the guide
  • Included links to new configuration profiles in the solutions folder
  • Added alternative option for enrolling in to cloud management

Summary by CodeRabbit

Release Notes

  • Documentation
    • Added configuration profile for Windows enabling Google Chrome enrollment to enterprise management console, allowing IT administrators to manage Chrome instances across the organization.

GrayW added 4 commits June 6, 2026 10:48
Add an example ADMX file for Google Chrome management
Add an example profile for enrolling Chrome to the enterprise console
Improve layout and instructions
@GrayW GrayW requested a review from ddribeiro as a code owner June 6, 2026 10:37
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 6, 2026

Lost in the diff? Review this PR in Change Stack to follow the change map from intent to exact ranges.

Review Change Stack

Walkthrough

This PR introduces a Windows configuration profile in XML format that enables Chrome cloud management enrollment through Microsoft MDM policies. The profile sets the CloudManagementEnrollmentToken policy with a specific UUID value using SyncML <Replace> syntax. The configuration allows Chrome browsers managed through Windows devices to enroll in enterprise console management.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Grayw guides update managinggooglechrome' is partially related to the changeset but is vague and poorly formatted, lacking clarity about the specific update. Revise the title to be more descriptive and clear, such as 'Add Google Chrome enterprise enrollment configuration profile and update management guide' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description addresses the main objectives and links to issue #46637, but does not follow the provided template structure with required checklists.
Linked Issues check ✅ Passed The PR includes XML configuration profile for Chrome enterprise console enrollment and guide updates that directly address issue #46637 requirements for sample configuration and guide improvements.
Out of Scope Changes check ✅ Passed The changes are scoped to documentation and configuration profiles for managing Google Chrome, all directly related to the linked issue #46637 objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch grayw-guides-update-managinggooglechrome

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/solutions/windows/configuration-profiles/enroll` Google Chrome to
enterprise console.xml:
- Line 7: The CloudManagementEnrollmentToken value currently contains a
UUID-like example that can be accidentally copied and break enrollment; update
the <Data> element so the CloudManagementEnrollmentToken attribute uses an
explicit placeholder (e.g., "REPLACE_WITH_ENROLLMENT_TOKEN") or a clearly marked
example UUID plus "replace this" text; locate the Data tag containing data
id="CloudManagementEnrollmentToken" and change its value attribute to the
placeholder text to prevent silent copy/paste failures.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 916a42e1-89da-4125-ac63-e6843eb79097

📥 Commits

Reviewing files that changed from the base of the PR and between ed50c8a and baa93e2.

⛔ Files ignored due to path filters (1)
  • articles/managing-chrome-with-fleet.md is excluded by !**/*.md
📒 Files selected for processing (2)
  • docs/solutions/windows/configuration-profiles/admx Google Chrome.xml
  • docs/solutions/windows/configuration-profiles/enroll Google Chrome to enterprise console.xml

<LocURI>./Device/Vendor/MSFT/Policy/Config/chrome~Policy~googlechrome/CloudManagementEnrollmentToken</LocURI>
</Target>
<Meta><Format xmlns="syncml:metinf">chr</Format></Meta>
<Data>&lt;enabled/&gt;&lt;data id=&quot;CloudManagementEnrollmentToken&quot; value=&quot;xxxxxxx-xxxx-43d3-b227-689c148ec054&quot;/&gt;</Data>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use an explicit placeholder token format to avoid copy/paste enrollment failures.

Line 7 currently shows a UUID-like value with an invalid shape (7-4-4-4-12), which is easy to copy as-is and silently break Chrome enrollment. Prefer a clearly named placeholder (or a valid UUID example with a “replace this” note).

Suggested doc-safe fix
-    <Data>&lt;enabled/&gt;&lt;data id=&quot;CloudManagementEnrollmentToken&quot; value=&quot;xxxxxxx-xxxx-43d3-b227-689c148ec054&quot;/&gt;</Data>
+    <Data>&lt;enabled/&gt;&lt;data id=&quot;CloudManagementEnrollmentToken&quot; value=&quot;YOUR_CLOUD_MANAGEMENT_ENROLLMENT_TOKEN_UUID&quot;/&gt;</Data>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Data>&lt;enabled/&gt;&lt;data id=&quot;CloudManagementEnrollmentToken&quot; value=&quot;xxxxxxx-xxxx-43d3-b227-689c148ec054&quot;/&gt;</Data>
<Data>&lt;enabled/&gt;&lt;data id=&quot;CloudManagementEnrollmentToken&quot; value=&quot;YOUR_CLOUD_MANAGEMENT_ENROLLMENT_TOKEN_UUID&quot;/&gt;</Data>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/solutions/windows/configuration-profiles/enroll` Google Chrome to
enterprise console.xml at line 7, The CloudManagementEnrollmentToken value
currently contains a UUID-like example that can be accidentally copied and break
enrollment; update the <Data> element so the CloudManagementEnrollmentToken
attribute uses an explicit placeholder (e.g., "REPLACE_WITH_ENROLLMENT_TOKEN")
or a clearly marked example UUID plus "replace this" text; locate the Data tag
containing data id="CloudManagementEnrollmentToken" and change its value
attribute to the placeholder text to prevent silent copy/paste failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update "Managing Google Chrome" with Fleet article

1 participant