[plz don't merge] test of a change that should not auto-approve#4829
Closed
mikermcneil wants to merge 2 commits intomainfrom
Closed
[plz don't merge] test of a change that should not auto-approve#4829mikermcneil wants to merge 2 commits intomainfrom
mikermcneil wants to merge 2 commits intomainfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/fleet-dm/fleet/DP8kHkYD76f3GP18W1azKrtDpwbh |
|
|
Member
Author
|
👍 |
should still NOT auto-approve if including a file where auto approval SHOULD happen, since PR contains ≥1 edit to a file where auto-approval is not appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a test to prove the fix in #4828 works properly