Skip to content

Update Fleet-maintained apps#48347

Merged
allenhouchins merged 2 commits into
mainfrom
fma-2606261635
Jun 26, 2026
Merged

Update Fleet-maintained apps#48347
allenhouchins merged 2 commits into
mainfrom
fma-2606261635

Conversation

@fleet-release

@fleet-release fleet-release commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Bug Fixes
    • Updated version information, download links, and package checksums for several managed apps, including Alcove, BetterTouchTool, draw.io, Granola, Lens, Marked, Microsoft Edge, WeChat, and XnView MP.
    • Added an update lock for VNC Viewer to keep its current package version fixed.

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 607eb9dc-66bb-474f-8098-c4b767731aad

📥 Commits

Reviewing files that changed from the base of the PR and between a20c58b and 80f4626.

📒 Files selected for processing (1)
  • ee/maintained-apps/inputs/winget/vnc-viewer.json

Walkthrough

The PR updates several maintained-app JSON outputs for newer Darwin and Windows releases by changing version values, patched-query thresholds, installer URLs, and SHA256 checksums. It also adds a top-level frozen: true flag to the Winget vnc-viewer input manifest.

Possibly related PRs

  • fleetdm/fleet#46204: Updates the same Lens Darwin manifest with a matching version bump and installer metadata change.
  • fleetdm/fleet#48260: Updates the same Alcove Darwin manifest version threshold in queries.patched.
  • fleetdm/fleet#48029: Updates the same Marked Darwin manifest version and installer metadata.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits the required template sections, issue reference, checklist, and testing details. Expand the description to follow the template, add the related issue, and complete the relevant checklist and testing sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: automated updates to Fleet-maintained app data.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2606261635

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/lens/darwin.json`:
- Around line 9-12: The Lens Darwin manifest is using a single arm64-only
installer_url for the generic darwin entry, which will break Intel Macs. Update
the maintained-apps manifest generation/config so darwin is split into
arch-specific variants like darwin/arm64 and darwin/amd64, or switch to a
verified universal DMG, and make sure each variant in maintained_apps.go gets
the correct installer_url and sha256 for its architecture.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 024a9157-be4f-402e-b2d5-6ec3d4bbe646

📥 Commits

Reviewing files that changed from the base of the PR and between 005bcdc and a20c58b.

📒 Files selected for processing (11)
  • ee/maintained-apps/outputs/alcove/darwin.json
  • ee/maintained-apps/outputs/bettertouchtool/darwin.json
  • ee/maintained-apps/outputs/drawio/darwin.json
  • ee/maintained-apps/outputs/granola/darwin.json
  • ee/maintained-apps/outputs/lens/darwin.json
  • ee/maintained-apps/outputs/lens/windows.json
  • ee/maintained-apps/outputs/marked-app/darwin.json
  • ee/maintained-apps/outputs/microsoft-edge/windows.json
  • ee/maintained-apps/outputs/vnc-viewer/windows.json
  • ee/maintained-apps/outputs/wechat/darwin.json
  • ee/maintained-apps/outputs/xnviewmp/windows.json

Comment on lines +9 to +12
"installer_url": "https://api.k8slens.dev/binaries/Lens-2026.6.260931-latest-arm64.dmg",
"install_script_ref": "e8691291",
"uninstall_script_ref": "ea665c04",
"sha256": "8a01626fb62009a77718adcaa063063957b7061c5070c785f64568452fce684f",
"sha256": "b30b9266baf85485e42acc819e838b202cbeb8b6c03a1a295453547aa548abdc",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

What macOS artifacts are published for Lens version 2026.6.260931-latest, and is Lens-2026.6.260931-latest-arm64.dmg Apple-Silicon-only or a universal build?

💡 Result:

For Lens desktop application releases, the software is distributed via architecture-specific DMG binaries rather than a single universal build [1][2]. The file Lens-2026.6.260931-latest-arm64.dmg is an Apple-Silicon-only build specifically optimized for ARM64-based macOS devices [1][2]. Lens publishes separate artifacts for different CPU architectures to support both Intel and Apple Silicon Macs [1][2]. Typically, these artifacts are available through the official Lens download portal and are structured as follows: 1. Intel (x64) build: Usually named without an architecture suffix or with an -x64 suffix [1][2]. 2. Apple Silicon (ARM64) build: Specifically appended with -arm64, such as the file you identified [1][2]. You can verify and download the appropriate architecture-specific binaries for your system via the official Lens download documentation and the binary distribution API [3][4][5]. The Homebrew cask for Lens also confirms this pattern, explicitly defining separate SHA256 hashes and URLs for arm64 and intel architectures [1][2].

Citations:


Correct the macOS Lens artifact URL to support all Darwin architectures.

The current installer_url in ee/maintained-apps/outputs/lens/darwin.json points to Lens-2026.6.260931-latest-arm64.dmg, which is an Apple-Silicon-only build. Since the darwin.json manifest applies to all macOS hosts, Intel-based Macs will attempt to download an incompatible binary.

Split the darwin platform entry into architecture-specific variants (darwin/arm64 and darwin/amd64) with corresponding URLs and hashes, or provide a verified universal DMG URL.

Diff Context
      "installer_url": "https://api.k8slens.dev/binaries/Lens-2026.6.260931-latest-arm64.dmg",
      "install_script_ref": "e8691291",
      "uninstall_script_ref": "ea665c04",
      "sha256": "b30b9266baf85485e42acc819e838b202cbeb8b6c03a1a295453547aa548abdc",

[maintained_apps.go] defines the manifest structure at the platform level, requiring architectural separation at the configuration level to ensure correct runtime downloads.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/lens/darwin.json` around lines 9 - 12, The Lens
Darwin manifest is using a single arm64-only installer_url for the generic
darwin entry, which will break Intel Macs. Update the maintained-apps manifest
generation/config so darwin is split into arch-specific variants like
darwin/arm64 and darwin/amd64, or switch to a verified universal DMG, and make
sure each variant in maintained_apps.go gets the correct installer_url and
sha256 for its architecture.

Mark the WinGet VNC Viewer input as frozen and update the generated Windows package metadata to RealVNC Connect Viewer 8.4.1.10, including the patched version query, installer URL, and checksum.
@allenhouchins allenhouchins merged commit 0f6b60e into main Jun 26, 2026
13 checks passed
@allenhouchins allenhouchins deleted the fma-2606261635 branch June 26, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants