new "checked for vulnerabilities" entry#5435
Conversation
Adding to knowledge base from #4946
There was a problem hiding this comment.
EDIT: Please ignore the feedback about renaming the page. We can come back and address this in a later pass.
Looking really good! I have a couple larger pieces of feedback in this comment and then several other comments and requests in comments below:
I think we can move the new section you added to the top of this documentation page (first section). This is because we expect that the user visiting this page is primarily attempting to achieve the goal of understanding the vulnerability coverage Fleet offers.
I also think it makes sense to change the title of this documentation page to "Vulnerable software."
This way, the page's title clearly communicates that Fleet offers a vulnerable software feature and not the vulnerability scanner feature set (vulnerable software, cloud configuration, networks, libraries, and dependencies) that other vuln management solutions offer.
Please check in with @eashaw on changing the title of documentation pages. I'm not sure how the links for fleetdm.com/docs react to changing the name of the markdown file.
Also, please check if this name change will result in any broken links in the Fleet product. You can do this by searching the Fleet repo for the current link: https://fleetdm.com/docs/using-fleet/vulnerability-processing
This is rocking!
|
@xpkoala please ignore my earlier piece of feedback about renaming the page. We can come back and address this in a later pass. |
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
xpkoala
left a comment
xpkoala
left a comment
There was a problem hiding this comment.
Added suggestions from @noahtalerman
noahtalerman
left a comment
noahtalerman
left a comment
There was a problem hiding this comment.
Looking sweet. I left a couple suggested changes below.
|
@xpkoala heads up, I left a couple suggested changes above. |
1 similar comment
|
@xpkoala heads up, I left a couple suggested changes above. |
Rename and move Coverage section to second listing.
xpkoala
left a comment
xpkoala
left a comment
There was a problem hiding this comment.
Renamed and moved Coverage section to be higher in the document.
noahtalerman
left a comment
noahtalerman
left a comment
There was a problem hiding this comment.
@xpkoala this is looking really good. I left several more requested changes below.
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
xpkoala
left a comment
xpkoala
left a comment
There was a problem hiding this comment.
Changed software to packages and other minor fixes.
| - RPM | ||
| - Atom | ||
| - Python | ||
| - Packages installed using APT (Debian) |
There was a problem hiding this comment.
The only reason "Packages installed using YUM (Red Hat)" is in here is because we thought the query Fleet runs to collect software includes the apt_sources table. This is not the case.
There was a problem hiding this comment.
apt_sources lists the repositories APT uses, not the packages.
| - Python | ||
| - Packages installed using APT (Debian) | ||
| - Packages installed using Portage (Gentoo) | ||
| - Packages installed using YUM (Red Hat) |
There was a problem hiding this comment.
@chiiph great catch.
The only reason "Packages installed using YUM (Red Hat)" is in here is because we thought the query Fleet runs to collect software includes the yum_sources table. This is not the case.
There was a problem hiding this comment.
yum_sources iiuc lists the respositories, not the packages.
chiiph
left a comment
chiiph
left a comment
There was a problem hiding this comment.
Looks good, just left a couple of comments that were technically redundant.
noahtalerman
left a comment
noahtalerman
left a comment
There was a problem hiding this comment.
@xpkoala I added two more requested changes following feedback from Tomas.
Pumped to get this merged today!
|
Editor pass completed on: |
Editor pass for: - #5435
4 participants
Adding to knowledge base from #4946