Skip to content

Simplify adding hosts page#5830

Merged
noahtalerman merged 4 commits intomainfrom
adding-hosts-revamp
May 23, 2022
Merged

Simplify adding hosts page#5830
noahtalerman merged 4 commits intomainfrom
adding-hosts-revamp

Conversation

@DominusKelvin
Copy link
Copy Markdown
Contributor

Resolves #5438

Copy link
Copy Markdown
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I really like that you reduced the amount of instruction above the fold. I added suggested changes below.

Comment thread docs/Using-Fleet/Adding-hosts.md Outdated
@noahtalerman
Copy link
Copy Markdown
Member

noahtalerman commented May 23, 2022

@DominusKelvin I propose that we add a sentence, to the minimum (MVP) instructions, that tells the user to "install the installer on your host."

This is because I think installing the installer on a host is part of the minimum required steps to get your host to talk to Fleet.

To address this, there's two approaches I can think of...

We move this sentence, from the bottom of the "Osquery installer" section, to the top, MVP section: "When you install an osquery installer on a host, this host will be automatically enrolled in the specified Fleet instance."

OR we move the same sentence^ to the top (first sentence) of the "Osquery installer" section.

What do you think?

Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 23, 2022 15:01 Inactive
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 23, 2022 15:01 Inactive
@DominusKelvin DominusKelvin temporarily deployed to Docker Hub May 23, 2022 15:13 Inactive
@DominusKelvin
Copy link
Copy Markdown
Contributor Author

@noahtalerman I did a quick read and I think where the sentence is currently is sort of good enough because it's right after we talked about the installer.

Copy link
Copy Markdown
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Looks good.

@noahtalerman noahtalerman merged commit 4c53adc into main May 23, 2022
@noahtalerman noahtalerman deleted the adding-hosts-revamp branch May 23, 2022 20:16
Desmi-Dizney added a commit that referenced this pull request May 24, 2022
@Desmi-Dizney
Copy link
Copy Markdown
Contributor

Editor pass completed on:

noahtalerman pushed a commit that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the adding hosts section of the docs

3 participants