Conversation
zwass
left a comment
There was a problem hiding this comment.
Nice summary! A few copy edits from me.
Would be great to make sure that someone who's been working with this more recently gets eyes on this before merging.
roperzh
left a comment
There was a problem hiding this comment.
❤️ very very nice, and super useful.
It would be amazing if we also mention some of the logic we have in place to modify the response (which can't be done directly at the handler):
fleet/server/service/transport.go
Lines 36 to 46 in be77594
| In order to use this new Datastore function we created, the layer that is in communication with it is the `Service` | ||
| which is both [an interface](https://github.com/fleetdm/fleet/blob/main/server/fleet/service.go#L41) and | ||
| [a struct](https://github.com/fleetdm/fleet/blob/main/server/service/service.go#L25) that implements that interface. |
There was a problem hiding this comment.
I think it would benefit the reader if we're more precise here, we have an interface fleet.Service and an struct service.Service that implements the interface.
mna
left a comment
There was a problem hiding this comment.
LGTM! Left a couple comments about possible missing pieces of info.
|
Editor pass completed on: |
Editor pass for: - #6290
No description provided.