Skip to content

Editor pass - Add debugging guide#6511

Merged
Desmi-Dizney merged 1 commit intomainfrom
Desmi-Dizney-patch-2
Jul 11, 2022
Merged

Editor pass - Add debugging guide#6511
Desmi-Dizney merged 1 commit intomainfrom
Desmi-Dizney-patch-2

Conversation

@Desmi-Dizney
Copy link
Copy Markdown
Contributor

Editor pass for:

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes (in changes/ and/or orbit/changes/).
  • Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md)
  • Documented any permissions changes
  • Ensured that input data is properly validated, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • Manual QA for all new/changed functionality

@Desmi-Dizney Desmi-Dizney requested a review from noahtalerman July 6, 2022 16:40
@Desmi-Dizney Desmi-Dizney mentioned this pull request Jul 6, 2022
@noahtalerman noahtalerman requested review from chiiph and removed request for noahtalerman July 8, 2022 14:11
@noahtalerman
Copy link
Copy Markdown
Member

@chiiph can you please help me review this editor pass to the "Debugging" page? Thanks :)

@Desmi-Dizney
Copy link
Copy Markdown
Contributor Author

@chiiph and @noahtalerman. Is it ok to merge docs during a mergefreeze as one would a handbook entry?

@chiiph
Copy link
Copy Markdown
Contributor

chiiph commented Jul 11, 2022

@chiiph and @noahtalerman. Is it ok to merge docs during a mergefreeze as one would a handbook entry?

Yes, for docs it's fine. But also at this point the freeze is over :)

@Desmi-Dizney Desmi-Dizney merged commit 8656bb5 into main Jul 11, 2022
@Desmi-Dizney Desmi-Dizney deleted the Desmi-Dizney-patch-2 branch July 11, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants