add configuration to retrieve installers from S3#6630
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 6365-global-enroll-secret #6630 +/- ##
==========================================================
Coverage 59.62% 59.63%
==========================================================
Files 398 398
Lines 37248 37257 +9
==========================================================
+ Hits 22209 22218 +9
Misses 12845 12845
Partials 2194 2194
Continue to review full report at Codecov.
|
roperzh
commented
Jul 12, 2022
Contributor
Author
There was a problem hiding this comment.
most of the contents here are copy-pasta from carves, but things like this have been edited accordingly.
8 tasks
lucasmrod
reviewed
Jul 13, 2022
lucasmrod
reviewed
Jul 13, 2022
lucasmrod
approved these changes
Jul 13, 2022
1 task
roperzh
added a commit
that referenced
this pull request
Jul 14, 2022
In #6630 I added a new config for packaging, but when I started the server I got: ``` ~/fleet $ ./build/fleet serve --dev --dev_license level=info ts=2022-07-13T21:36:06.055998Z component=redis mode=standalone fatal error: newproc: function arguments too large for new goroutine runtime stack: runtime.throw({0x103d85259, 0x37}) /Users/roperzh/.gvm/gos/go1.17/src/runtime/panic.go:1198 +0x54 runtime.newproc1(0x104569a30, 0x14000ffda28, 0x7f8, 0x140000001a0, 0x103bc85a4) /Users/roperzh/.gvm/gos/go1.17/src/runtime/proc.go:4299 +0x4d0 runtime.newproc.func1() /Users/roperzh/.gvm/gos/go1.17/src/runtime/proc.go:4255 +0x4c runtime.systemstack() /Users/roperzh/.gvm/gos/go1.17/src/runtime/asm_arm64.s:230 +0x6c goroutine 1 [running]: runtime.systemstack_switch() /Users/roperzh/.gvm/gos/go1.17/src/runtime/asm_arm64.s:187 +0x8 fp=0x14000ffd9c0 sp=0x14000ffd9b0 pc=0x102b60958 runtime.newproc(0x7f8, 0x104569a30) /Users/roperzh/.gvm/gos/go1.17/src/runtime/proc.go:4254 +0x54 fp=0x14000ffda10 sp=0x14000ffd9c0 pc=0x102b38034 main.runCrons({0x1045cd500, 0x14000262990}, {0x104611a38, 0x14000262930}, 0x14000298190, {0x1045a0480, 0x140009c9f20}, {{{0x103d1adc4, 0x3}, {0x103d2b188, ...}, ...}, ...}, ...) /Users/roperzh/fleet/cmd/fleet/serve.go:694 +0x2c4 fp=0x14000ffe260 sp=0x14000ffda10 pc=0x103bc85a4 main.createServeCmd.func1(0x1400027ca00, {0x140000bcb40, 0x0, 0x2}) ``` With my local changes, `serve.go:694` is this line: https://github.com/fleetdm/fleet/blob/7559988000efc3d7408d9914edd5a3f2f1052138/cmd/fleet/serve.go#L685-L686 After passing only a subset of the config the issue was solved.
Contributor
|
Editor pass completed on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6365, this adds relevant configuration to the
packagingkey to retrieve installers from S3.Checklist for submitter
changes/and/ororbit/changes/).