Skip to content

Markdown guide for the handbook#6864

Merged
mike-j-thomas merged 13 commits into
mainfrom
handbook-markdown-guide
Aug 4, 2022
Merged

Markdown guide for the handbook#6864
mike-j-thomas merged 13 commits into
mainfrom
handbook-markdown-guide

Conversation

@mike-j-thomas
Copy link
Copy Markdown
Member

@mike-j-thomas mike-j-thomas commented Jul 26, 2022

Markdown guide for the handbook.

Markdown guide for the handbook.
fleet-release
fleet-release previously approved these changes Jul 26, 2022
@mike-j-thomas
Copy link
Copy Markdown
Member Author

mike-j-thomas commented Jul 26, 2022

Created this draft PR for 2nd level handbook content with @Desmi-Dizney.

  • Des to update titles, and then v1 is ready to merge.

@Desmi-Dizney Desmi-Dizney temporarily deployed to Docker Hub July 26, 2022 03:29 Inactive
@Desmi-Dizney Desmi-Dizney temporarily deployed to Docker Hub July 26, 2022 15:55 Inactive
@Desmi-Dizney Desmi-Dizney temporarily deployed to Docker Hub July 26, 2022 16:11 Inactive
@Desmi-Dizney Desmi-Dizney marked this pull request as ready for review July 26, 2022 16:12
@Desmi-Dizney Desmi-Dizney requested a review from eashaw July 26, 2022 16:13
@Desmi-Dizney Desmi-Dizney temporarily deployed to Docker Hub July 26, 2022 16:17 Inactive
@Desmi-Dizney Desmi-Dizney mentioned this pull request Jul 26, 2022
2 tasks
@Desmi-Dizney Desmi-Dizney temporarily deployed to Docker Hub July 26, 2022 16:23 Inactive
fleet-release
fleet-release previously approved these changes Jul 27, 2022
@mikermcneil mikermcneil dismissed fleet-release’s stale review July 27, 2022 06:49

Ignore this review, sry, just testing the bot.

fleet-release
fleet-release previously approved these changes Jul 27, 2022
@mikermcneil mikermcneil dismissed fleet-release’s stale review July 27, 2022 07:23

Sweet it works now. You should get auto-unfrozen

Comment thread handbook/digital-experience/README.md Outdated
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub July 28, 2022 05:16 Inactive
Comment thread handbook/digital-experience/markdown-guide.md Outdated
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub July 28, 2022 05:18 Inactive
- I repositioned Markdown to be under Voice and tone.
@Desmi-Dizney, I think you are right. Including the Markdown section under the section for writers is better.
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub July 28, 2022 05:46 Inactive
Copy link
Copy Markdown
Member Author

@mike-j-thomas mike-j-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Desmi-Dizney, please can you address the following changes:

  • Change "Markdown option one" to "Markdown" since we are not including alt versions

  • Check the table column headings for correct sentence casing

  • Remove HTML cols from the example tables. Let's keep it simple and only show Markdown and Rendered output.

  • In the Emphasis section, please remove the row for underlining text. Markdown does not support underlining text, and underlining with HTML is not recommended as this is reserved for hyperlinks

  • In the Unordered list section, add an h3 for "Nesting unordered lists" above the nesting info

  • In the same section, add an h4 "Example" above your Markdown examples. Then add an h4 "Rendered output" in place of "This renders as"

  • The Links section is hard to read when it's rendered on the site. Let's break that section up into the following, using h3 tags for each subsection:

    • Inline link
    • Inline link with a tooltip
    • Relative link
    • URLs and email addresses
  • Here is an example of how to organize the subsections listed above:

Start of Mike T's example

Inline link

Example

[This is an inline link](https://fleetdm.com/handbook/digital-experience/markdown-guide.md)

Rendered output

This is an inline link

End of Mike T's example

  • "Type command + K for a simple link template." Unless I'm mistaken, I'm pretty sure that this only works in certain software, e.g. GitHub. Please add this as a Note. Something like:

Tip: In GitHub, you can highlight the text that you want to add a link to and hit command + K

  • Mailto section. Remove this section. Note that I suggested consolidating this under Links "URLs and email. Remember to move the note about never using mailto links before you delete it.
  • Add an h2 "Tables" and follow the same format mentioned previously. I.e., h4 "Example" followed by h4 "Rendered output."

@mike-j-thomas mike-j-thomas linked an issue Jul 31, 2022 that may be closed by this pull request
2 tasks
- actioned review comments (#6864 (review))
- reformatted the markdown guide.
- updated nested list examples to display inside a table
- removed a couple of link examples that don't currently render on the website
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub August 3, 2022 08:48 Inactive
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub August 3, 2022 08:52 Inactive
@mike-j-thomas
Copy link
Copy Markdown
Member Author

Hey @Desmi-Dizney, I have a couple of tasks that I needed to push live that point to this guide, so I actioned my previous review feedback. I also solved how to render nested lists within a table. You can check it out in the Files changed tab if you're interested in how to do that for future reference.

- I removed the Markdown section. I'd prefer to link to this guide as and when it's needed.
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub August 3, 2022 09:11 Inactive
@fleet-release fleet-release added the ~handbook Involves writing in the Fleet handbook (fleetdm.com/handbook) label Aug 4, 2022
@mike-j-thomas mike-j-thomas removed the request for review from chris-mcgillicuddy August 4, 2022 02:45
@mike-j-thomas mike-j-thomas merged commit cbc4565 into main Aug 4, 2022
@mike-j-thomas mike-j-thomas deleted the handbook-markdown-guide branch August 4, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~handbook Involves writing in the Fleet handbook (fleetdm.com/handbook)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown guide

3 participants