Website: Minor scripts/build-static-content.js updates#6974
Merged
mikermcneil merged 6 commits intomainfrom Aug 2, 2022
Merged
Website: Minor scripts/build-static-content.js updates#6974mikermcneil merged 6 commits intomainfrom
mikermcneil merged 6 commits intomainfrom
Conversation
Member
mikermcneil
requested changes
Aug 2, 2022
Member
mikermcneil
left a comment
mikermcneil
left a comment
There was a problem hiding this comment.
Everything LGTM except what I already changed and this minor tweak
| throw new Error('Failed compiling markdown content: Files as currently named would result in colliding (duplicate) URLs for the website. To resolve, rename the pages whose names are too similar. Duplicate detected: ' + rootRelativeUrlPath); | ||
| }//• | ||
| rootRelativeUrlPathsSeen.push(rootRelativeUrlPath); | ||
|
|
Member
There was a problem hiding this comment.
I'd move this up slightly to put it before where we generate the htmlId, so that that the code about deciding the htmlId can stay right next to the code that determines the HTML output path and writes it.
mikermcneil
approved these changes
Aug 2, 2022
Member
mikermcneil
left a comment
mikermcneil
left a comment
There was a problem hiding this comment.
I went ahead and made the change. As long as that passes lint, then this looks good to merge to me.
fleet-release
approved these changes
Aug 2, 2022
mikermcneil
changed the title
fleet-release
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/fleetdm/confidential/issues/1537