Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the stacking issues when filtering points
Description
This PR ensures that the order of points to be filtered cannot be altered externally. E.g.,
scatterplot.filter([0, 1])andscatterplot.filter([1, 0])is now going to give the same results. Previously, the order of point IDs defined the drawing order.Fixes #197
Following the example from #197, when filtering by
scatterplot.filter([0, 1]), the following happened:Previously
Screen.Recording.2024-11-22.at.1.33.32.PM.mov
Now
Screen.Recording.2024-11-22.at.1.34.10.PM.mov
Checklist
CHANGELOG.mdupdatedREADME.mdadded or updated