This repository was archived by the owner on Dec 24, 2025. It is now read-only.
v1: Remove _async suffix from all methods, remove fire-n-forget counterparts, code improvements#9
Merged
FeodorFitsner merged 3 commits intomainfrom Aug 18, 2025
Merged
v1: Remove _async suffix from all methods, remove fire-n-forget counterparts, code improvements#9FeodorFitsner merged 3 commits intomainfrom
FeodorFitsner merged 3 commits intomainfrom
Conversation
Deploying flet-map-docs with
|
| Latest commit: |
f34ac45
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09695d62.flet-map-docs.pages.dev |
| Branch Preview URL: | https://dev.flet-map-docs.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the flet-map library's API by removing the _async suffix from all methods and eliminating fire-and-forget counterparts to simplify the interface. It also includes code improvements and standardizes import patterns across the codebase.
- Renamed all async methods to remove
_asyncsuffix (e.g.,rotate_from_async→rotate_from) - Removed synchronous fire-and-forget methods that used
asyncio.create_taskinternally - Updated all relative imports to absolute imports for better consistency
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/flet_map/map.py | Removed _async suffixes from methods, deleted synchronous counterparts, updated to absolute imports |
| src/flet_map/*.py | Converted relative imports to absolute imports using flet_map. prefix |
| src/flutter/flet_map/lib/src/utils/map.dart | Minor formatting improvements to method parameters |
| examples/map_example/src/example_1.py | Updated to use constant instead of method call for alignment |
| pyproject.toml | Added mkdocs-external-images dependency with git source |
| mkdocs.yml | Added external images plugin configuration and removed deprecated filter |
| docs/*.md | Updated documentation structure and examples |
| appveyor.yml | Modernized CI configuration to use uv for Python management |
| .ci/*.py | Added PEP 723 script dependencies headers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
FeodorFitsner
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.