Skip to content
This repository was archived by the owner on Dec 24, 2025. It is now read-only.

v1: Remove _async suffix from all methods, remove fire-n-forget counterparts, code improvements#9

Merged
FeodorFitsner merged 3 commits intomainfrom
dev
Aug 18, 2025
Merged

v1: Remove _async suffix from all methods, remove fire-n-forget counterparts, code improvements#9
FeodorFitsner merged 3 commits intomainfrom
dev

Conversation

@ndonkoHenri
Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying flet-map-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f34ac45
Status: ✅  Deploy successful!
Preview URL: https://09695d62.flet-map-docs.pages.dev
Branch Preview URL: https://dev.flet-map-docs.pages.dev

View logs

@ndonkoHenri ndonkoHenri marked this pull request as ready for review August 16, 2025 17:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the flet-map library's API by removing the _async suffix from all methods and eliminating fire-and-forget counterparts to simplify the interface. It also includes code improvements and standardizes import patterns across the codebase.

  • Renamed all async methods to remove _async suffix (e.g., rotate_from_asyncrotate_from)
  • Removed synchronous fire-and-forget methods that used asyncio.create_task internally
  • Updated all relative imports to absolute imports for better consistency

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/flet_map/map.py Removed _async suffixes from methods, deleted synchronous counterparts, updated to absolute imports
src/flet_map/*.py Converted relative imports to absolute imports using flet_map. prefix
src/flutter/flet_map/lib/src/utils/map.dart Minor formatting improvements to method parameters
examples/map_example/src/example_1.py Updated to use constant instead of method call for alignment
pyproject.toml Added mkdocs-external-images dependency with git source
mkdocs.yml Added external images plugin configuration and removed deprecated filter
docs/*.md Updated documentation structure and examples
appveyor.yml Modernized CI configuration to use uv for Python management
.ci/*.py Added PEP 723 script dependencies headers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@FeodorFitsner FeodorFitsner merged commit 8507cda into main Aug 18, 2025
4 checks passed
@FeodorFitsner FeodorFitsner deleted the dev branch August 18, 2025 00:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants