Skip to content

Add console as a build argument #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Add console as a build argument #2146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75eb310
Add console to be a build argument
doug-benn Nov 2, 2023
b5679ed
Fixed duplicate line & Replace - with _ in arg dest
doug-benn Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sdk/python/packages/flet/src/flet/cli/commands/pack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ def add_arguments(self, parser: argparse.ArgumentParser) -> None:
dest="bundle_id",
help="bundle identifier (macOS)",
)
parser.add_argument(
"--debug-console",
dest="debug_console",
help="Show python console (Ensure correct DEBUG level)",
)

def handle(self, options: argparse.Namespace) -> None:
# delete "build" directory
Expand All @@ -118,7 +123,9 @@ def handle(self, options: argparse.Namespace) -> None:
import PyInstaller.__main__
from flet.__pyinstaller.utils import copy_flet_bin

pyi_args = [options.script, "--noconsole", "--noconfirm"]
pyi_args = [options.script, "--noconfirm"]
if not options.debug_console:
pyi_args.extend(["--noconsole"])
if options.icon:
pyi_args.extend(["--icon", options.icon])
if options.name:
Expand Down