Skip to content

Conversation

@skeledrew
Copy link
Contributor

  • Check if git is installed.

  • Ensure proper working directory when used in another project.

  • Use the version of the active branch.

  • Improved error messages if tag retrieval fails.

- Check if `git` is installed.

- Ensure proper working directory when used in another project.

- Use the version of the active branch.

- Improved error messages if tag retrieval fails.
@FeodorFitsner
Copy link
Contributor

It doesn't work for me on Windows 11, I'm always getting hardcoded 0.1.60.

Removing which("git") and makes it work. Why?

@FeodorFitsner
Copy link
Contributor

Got it! It should check for which("git.exe") on Windows and for which("git") on other OSes.

Could you do a fix please?

@FeodorFitsner FeodorFitsner merged commit 2aa8496 into flet-dev:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants