-
Notifications
You must be signed in to change notification settings - Fork 589
fix: improve InteractiveViewer programmatic transformations
#5775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ndonkoHenri
wants to merge
7
commits into
main
Choose a base branch
from
fix-interactive-viewer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+576
−67
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ec57b0e
initial commit
ndonkoHenri 43d2398
more docs
ndonkoHenri 9b8fad8
example + docs
ndonkoHenri 4e4d685
cleanup
ndonkoHenri 3e69cc4
comment code and fix dart analysis
ndonkoHenri 94380a8
refactor: enhance documentation for reorderable components
ndonkoHenri 01b2b3f
fix `ScaleUpdateDetails.toMap()`
ndonkoHenri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
356 changes: 345 additions & 11 deletions
356
packages/flet/lib/src/controls/interactive_viewer.dart
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
sdk/python/examples/controls/interactive_viewer/transformations.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import flet as ft | ||
|
|
||
|
|
||
| def main(page: ft.Page): | ||
| page.horizontal_alignment = ft.CrossAxisAlignment.CENTER | ||
| page.vertical_alignment = ft.MainAxisAlignment.CENTER | ||
|
|
||
| async def handle_zoom_in(e: ft.Event[ft.Button]): | ||
| await i.zoom(1.2) | ||
|
|
||
| async def handle_zoom_out(e: ft.Event[ft.Button]): | ||
| await i.zoom(0.8) | ||
|
|
||
| async def handle_pan(e: ft.Event[ft.Button]): | ||
| await i.pan(dx=50, dy=50) | ||
|
|
||
| async def handle_reset(e: ft.Event[ft.Button]): | ||
| await i.reset() | ||
|
|
||
| async def handle_reset_slow(e: ft.Event[ft.Button]): | ||
| await i.reset(animation_duration=ft.Duration(seconds=2)) | ||
|
|
||
| async def handle_save_state(e: ft.Event[ft.Button]): | ||
| await i.save_state() | ||
|
|
||
| async def handle_restore_state(e: ft.Event[ft.Button]): | ||
| await i.restore_state() | ||
|
|
||
| page.add( | ||
| i := ft.InteractiveViewer( | ||
| min_scale=0.1, | ||
| max_scale=5, | ||
| boundary_margin=ft.Margin.all(20), | ||
| content=ft.Image(src="https://picsum.photos/500/500"), | ||
| ), | ||
| ft.Row( | ||
| wrap=True, | ||
| controls=[ | ||
| ft.Button("Zoom In", on_click=handle_zoom_in), | ||
| ft.Button("Zoom Out", on_click=handle_zoom_out), | ||
| ft.Button("Pan", on_click=handle_pan), | ||
| ft.Button("Save State", on_click=handle_save_state), | ||
| ft.Button("Restore State", on_click=handle_restore_state), | ||
| ft.Button("Reset (instant)", on_click=handle_reset), | ||
| ft.Button("Reset (slow)", on_click=handle_reset_slow), | ||
| ], | ||
| ), | ||
| ) | ||
|
|
||
|
|
||
| ft.run(main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using a lambda in
default_factoryis unnecessarily verbose. Consider usingdefault_factory=lambda: Margin.all(0)can be simplified to a partial function or a named function if this pattern is repeated, or usefield(default_factory=Margin)ifMargin.all(0)is the default constructor behavior.