Skip to content

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Jan 18, 2026

Summary by Sourcery

Improve type evaluation compatibility, stabilize responsive row tests, and ensure desktop light package versions are patched in release scripts.

Bug Fixes:

  • Make control event and from_dict type resolution compatible with multiple inspect._eval_type signatures across Python versions.
  • Stabilize responsive row integration tests by waiting for UI to settle before taking screenshots and allowing more pump cycles for custom breakpoints.
  • Patch flet-desktop-light package version during release scripting instead of skipping it.
  • Ensure example audio player stops playback on release by setting an explicit release mode.

Enhancements:

  • Tidy example imports in the Rive control example for clearer usage.

Build:

  • Extend version patching script to handle flet-desktop-light safely by checking for version.py before applying edits.

Tests:

  • Adjust responsive row integration tests to wait for pump_and_settle and increase pump iterations for custom breakpoint scenarios.

Included 'flet-desktop-light' in the list of packages for version patching in the common.sh script. Enhanced responsive row integration tests by adding 'pump_and_settle' calls to ensure UI updates are fully processed before taking screenshots.
Introduced _eval_type_compat helper in control_event.py and from_dict.py to handle cases where _eval_type requires a type_params argument, improving compatibility across Python versions.
Reorders imports to place 'flet' before 'flet_rive' for consistency and clarity.
Added the release_mode parameter with value fta.ReleaseMode.STOP to the Audio widget in example_1.py to explicitly control audio playback behavior.
The patch_python_package_versions function now verifies that version.py exists before attempting to update it, preventing errors if the file is missing and logging a message when skipped.
Updated the test_custom_breakpoint function to run 10 pump iterations instead of 5 after resizing the page. This change may improve test reliability by allowing more time for UI updates to settle before assertions.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@FeodorFitsner FeodorFitsner merged commit 46321a4 into main Jan 18, 2026
49 of 52 checks passed
@FeodorFitsner FeodorFitsner deleted the fix-desktop-light branch January 18, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants