fix(charts): fix LineChart left_axis labels display incomplete #6445#6452
Closed
KangZhaoKui wants to merge 1 commit intoflet-dev:mainfrom
Closed
fix(charts): fix LineChart left_axis labels display incomplete #6445#6452KangZhaoKui wants to merge 1 commit intoflet-dev:mainfrom
KangZhaoKui wants to merge 1 commit intoflet-dev:mainfrom
Conversation
4 tasks
Contributor
|
Thank you so much for the report and the fix, @KangZhaoKui! You correctly diagnosed the root cause — float comparison with I've opened #6459 against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6445
Description
The bug was caused by floating-point precision errors in the axis label layout calculation.
Type of change
Screenshots
Summary by Sourcery
Bug Fixes: