Bump libxml2/libxslt/lxml; add recipe-bump skill#48
Merged
FeodorFitsner merged 4 commits intopython3.12from May 5, 2026
Merged
Bump libxml2/libxslt/lxml; add recipe-bump skill#48FeodorFitsner merged 4 commits intopython3.12from
FeodorFitsner merged 4 commits intopython3.12from
Conversation
Drive the source URL and patch selection from a single Jinja version variable so switching back to 2.9.8 still builds. Replace the old mobile.patch (config.sub iOS triplets + libxml2.syms tweaks for the 2.9 layout) with two version-targeted patches: mobile-2.9.x.patch keeps the original content, mobile-2.15.x.patch only teaches the modernized config.sub about *-apple-ios-simulator. build.sh: pass --without-iconv on Android (NDK bionic lacks iconv until API 28; 2.15.x makes it mandatory by default while 2.9.x silently soft-failed). Make the post-install cleanup tolerate the 2.15.x layout where share/ is no longer created and globs may not match (nullglob + rm -rf).
flet-libxslt: drive version, libxml2 host requirement, and patch
selection from a single Jinja block (numpy-style). Replace the old
mobile.patch (config.sub iOS triplets for the 1.1.32 layout) with
two version-targeted patches: mobile-1.1.32.patch keeps the original
content, mobile-1.1.45.patch only teaches the modernized config.sub
about *-apple-ios-simulator. 1.1.45 pulls in flet-libxml2 2.15.3 to
satisfy its >= 2.15.1 requirement.
build.sh: only recurse into libxslt/libexslt subdirs. xsltproc links
-lxml2 and on iOS the SDK's libxml2.tbd predates 1.1.45's use of
xmlCtxtParseDocument / xmlXPathValuePush, so the CLI binary fails to
link; the wheel only needs the libraries. Same cleanup robustness
fix as libxml2 (nullglob + rm -rf).
flet-libxml2 + flet-libxslt build.sh: stop deleting *.a from the
wheel's lib/. iOS only builds static libs, so the previous cleanup
left lib/ empty and forced downstream packages onto dynamic_lookup
or the SDK stub. Android only builds shared libs (no *.a produced),
so this is a no-op there.
flet-libxml2/meta.yaml: switch to the comment-prefixed Jinja idiom
(# {% ... %}) so YAML linters parse it cleanly, matching numpy and
flet-libxslt.
Drive version, libxml2/libxslt host pinning, and the iOS-only LDFLAGS=-liconv from a single Jinja block. lxml 5.x doesn't compile against libxml2 2.15 (per upstream's CHANGES) so the older lxml version stays paired with libxml2 2.9.8 / libxslt 1.1.32. iOS libxml2.a now references iconv (it's built --with-iconv against the system libiconv), and lxml's libraries() list omits iconv on non-Windows non-static builds. Add -liconv via script_env LDFLAGS on iOS only — Android's libxml2 is built --without-iconv and doesn't need it. The existing mobile.patch (filter MacOSX SDK include path out of xml2-config --cflags) still applies cleanly to 6.1.0.
Captures the conventions used while bumping flet-libxml2 (2.9.8 → 2.15.3), flet-libxslt (1.1.32 → 1.1.45), and lxml (5.3.0 → 6.1.0): the comment-prefixed Jinja idiom for version-conditional meta.yaml (URL, host pins, patch filename in one block), the build.sh quirks that bit us (bash 3.2 + set -u, nullglob cleanup, keeping *.a in the wheel, SUBDIRS overrides, --without-iconv on Android), the pitfall catalogue (iOS SDK libxml2.tbd, lxml's missing -liconv, config.sub ios-simulator gap, libxml2.syms removed in 2.10), and the forge CLI surface for re-running builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan