feat(): Enhance CoordinateSystemManager with entity validation and improve mirror status generation#1689
Merged
benflexcompute merged 1 commit intomainfrom Jan 2, 2026
Conversation
…prove mirror status generation - Updated the `_from_status` method in `CoordinateSystemManager` to accept an `entity_registry` for validating entity assignments. - Added a new method `_generate_mirror_status` in `MirrorManager` to streamline the creation of mirror status snapshots with entity validation. - Introduced `find_by_type_name_and_id` in `EntityRegistry` for precise entity lookups. - Updated tests to validate the new functionality and ensure proper handling of unknown entities and duplicate assignments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_from_statusmethod inCoordinateSystemManagerto accept anentity_registryfor validating entity assignments._generate_mirror_statusinMirrorManagerto streamline the creation of mirror status snapshots with entity validation.find_by_type_name_and_idinEntityRegistryfor precise entity lookups.