Skip to content

Conversation

@benflexcompute
Copy link
Collaborator

RotationVolumeSplitProvider was aggressively intercepting any boundary containing __rotating_, causing false positives for user-defined boundaries or boundaries not generated by the current rotation configuration.
This PR implements a multi-layer defense:

  1. Strict Name Checking: The provider now caches the exact full names it expects to generate and only intercepts those specific boundaries.
  2. Active Volume Check: The provider is only added to the lookup table if there are active RotationVolume zones with enclosed entities.
  3. Volume Mesh Bypass: The provider is skipped entirely when initializing from VolumeMeshEntityInfo, as split logic is unnecessary for pre-meshed volumes.
    Regression tests covering these scenarios have been added.

@benflexcompute benflexcompute changed the title fix: Prevent RotationVolumeSplitProvider from intercepting unrelated boundaries fix(): Prevent RotationVolumeSplitProvider from intercepting unrelated boundaries Jan 6, 2026
@shreyas-flex shreyas-flex merged commit 48a8860 into main Jan 6, 2026
20 checks passed
@shreyas-flex shreyas-flex deleted the BenY/FixImproperInterceptionByRotationVolumeSplitProvider branch January 6, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants