[FXC-4733] allow AxisymmetricBody in UniformRefinement#1744
Merged
alexxu-flex merged 19 commits intomainfrom Feb 6, 2026
Merged
[FXC-4733] allow AxisymmetricBody in UniformRefinement#1744alexxu-flex merged 19 commits intomainfrom
alexxu-flex merged 19 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
flow360/component/simulation/translator/volume_meshing_translator.py
Outdated
Show resolved
Hide resolved
flow360/component/simulation/translator/volume_meshing_translator.py
Outdated
Show resolved
Hide resolved
flow360/component/simulation/translator/volume_meshing_translator.py
Outdated
Show resolved
Hide resolved
flow360/component/simulation/translator/volume_meshing_translator.py
Outdated
Show resolved
Hide resolved
…symmetric-refinements
tests/simulation/params/meshing_validation/test_meshing_param_validation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…symmetric-refinements
benflexcompute
previously approved these changes
Feb 5, 2026
i forgot to change the validator name Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
benflexcompute
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/flexcompute/compute/pull/3399
Note
Medium Risk
Touches meshing schema validation and JSON translation paths; while gated to beta mesher for the new entity type, incorrect translation/validation could break meshing submissions for users exercising these refinements.
Overview
UniformRefinementnow acceptsAxisymmetricBodyentities in addition toBoxandCylinder, with validation that rejects axisymmetric bodies unless the beta (in-house) volume mesher is enabled.The volume-meshing translator is updated to emit Axisymmetric-body refinement JSON (via a shared
axisymmetric_body_injector), andAxisymmetricBodyvalidation is tightened to requireprofile_curveto have at least 2 points and disallow consecutive duplicate points; coverage is added for the new validation and translation behavior.Written by Cursor Bugbot for commit f4269b3. This will update automatically on new commits. Configure here.