Sphere entity and Spherical Sliding Interfaces#1759
Merged
shreyas-flex merged 13 commits intomainfrom Feb 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
benflexcompute
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spacing_*members optional, validation of presence occurs on construction of inherited classes (AxisymmetricRefinement, RotationVolume). This is because Sphere only needs one spacing for construction.Note
Medium Risk
Adds a new volume primitive and extends
RotationVolumetranslation/validation paths; risk is mainly incorrect meshing JSON output or overly-permissive/strict validation for beta vs legacy meshers.Overview
Adds a new
Spherevolume primitive (exported publicly and materialized viaENTITY_TYPE_MAP) with coordinate-system transformation support, and refactors uniform-scale validation into a shared helper used byBox/Cylinder/AxisymmetricBody/Sphere.Extends
RotationVolumeto acceptSphere(including asenclosed_entities) and introduces entity-type-specific spacing validation (Sphere requires onlyspacing_circumferential; cylinders/axisymmetric bodies still require all three), while keeping Sphere usage restricted to the beta mesher.Updates volume-meshing translation to emit spherical sliding-interface JSON (
type: Sphere,radius,axisOfRotation,center, andmaxEdgeLength) and to include Sphere enclosed-object references, with comprehensive new tests covering validation, transformation, entity creation, and translation.Written by Cursor Bugbot for commit ef21e4e. This will update automatically on new commits. Configure here.