Skip to content

Sphere entity and Spherical Sliding Interfaces#1759

Merged
shreyas-flex merged 13 commits intomainfrom
shreyas/sphere-entity
Feb 10, 2026
Merged

Sphere entity and Spherical Sliding Interfaces#1759
shreyas-flex merged 13 commits intomainfrom
shreyas/sphere-entity

Conversation

@shreyas-flex
Copy link
Copy Markdown
Contributor

@shreyas-flex shreyas-flex commented Feb 2, 2026

  • Adds Sphere entity and support for spherical sliding interfaces in RotationVolume.
  • Makes AxisymmetricRefinementBase spacing_* members optional, validation of presence occurs on construction of inherited classes (AxisymmetricRefinement, RotationVolume). This is because Sphere only needs one spacing for construction.
  • Adds translation for sphere sliding interfaces in the required style of Flynn360.

Note

Medium Risk
Adds a new volume primitive and extends RotationVolume translation/validation paths; risk is mainly incorrect meshing JSON output or overly-permissive/strict validation for beta vs legacy meshers.

Overview
Adds a new Sphere volume primitive (exported publicly and materialized via ENTITY_TYPE_MAP) with coordinate-system transformation support, and refactors uniform-scale validation into a shared helper used by Box/Cylinder/AxisymmetricBody/Sphere.

Extends RotationVolume to accept Sphere (including as enclosed_entities) and introduces entity-type-specific spacing validation (Sphere requires only spacing_circumferential; cylinders/axisymmetric bodies still require all three), while keeping Sphere usage restricted to the beta mesher.

Updates volume-meshing translation to emit spherical sliding-interface JSON (type: Sphere, radius, axisOfRotation, center, and maxEdgeLength) and to include Sphere enclosed-object references, with comprehensive new tests covering validation, transformation, entity creation, and translation.

Written by Cursor Bugbot for commit ef21e4e. This will update automatically on new commits. Configure here.

Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/entity_operation.py Outdated
Comment thread flow360/component/simulation/meshing_param/volume_params.py
Comment thread flow360/component/simulation/meshing_param/volume_params.py
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread flow360/component/simulation/meshing_param/volume_params.py
@shreyas-flex shreyas-flex enabled auto-merge (squash) February 5, 2026 14:47
Comment thread flow360/component/simulation/meshing_param/volume_params.py
Comment thread flow360/component/simulation/meshing_param/volume_params.py
@shreyas-flex shreyas-flex merged commit c17efb3 into main Feb 10, 2026
20 checks passed
@shreyas-flex shreyas-flex deleted the shreyas/sphere-entity branch February 10, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants