Skip to content

[FXC-3191] Added support for gravity#1764

Merged
awccoppFC merged 16 commits intomainfrom
nasser/gravity
Feb 18, 2026
Merged

[FXC-3191] Added support for gravity#1764
awccoppFC merged 16 commits intomainfrom
nasser/gravity

Conversation

@NasserFlexCompute
Copy link
Copy Markdown
Contributor

@NasserFlexCompute NasserFlexCompute commented Feb 3, 2026

Note

Medium Risk
Introduces a new physical model plus a new core unit dimension and conversion scaling, which could affect other unit conversions and solver JSON generation if mis-scaled or misused.

Overview
Adds a new Gravity model that can be attached to Fluid to apply a global gravitational body force, and exposes it from the top-level flow360 API.

Extends the v2 unit system and conversion pipeline with an acceleration dimension (including flow360_acceleration_unit and base scaling), and updates the solver translator to non-dimensionalize gravity and emit a solver gravityVector.

Adds test coverage for gravity defaults/customization/normalization, unit-system initialization with acceleration, and end-to-end translation/non-dimensionalization in get_solver_json.

Written by Cursor Bugbot for commit 1d10cf6. This will update automatically on new commits. Configure here.

@awccoppFC awccoppFC marked this pull request as ready for review February 11, 2026 16:45
Copilot AI review requested due to automatic review settings February 11, 2026 16:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@awccoppFC awccoppFC marked this pull request as draft February 11, 2026 16:45
Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/models/volume_models.py Outdated
@awccoppFC awccoppFC marked this pull request as ready for review February 12, 2026 15:56
@awccoppFC awccoppFC changed the title Added support for gravity [FXC-3191] Added support for gravity Feb 12, 2026
Comment thread flow360/component/simulation/unit_system.py
Comment thread flow360/component/simulation/unit_system.py
Comment thread flow360/component/simulation/models/volume_models.py Outdated
Comment thread flow360/component/simulation/translator/solver_translator.py Outdated
Comment thread flow360/component/simulation/unit_system.py
Comment thread flow360/component/simulation/unit_system.py
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread flow360/component/simulation/translator/solver_translator.py
Comment thread flow360/__init__.py
Comment thread tests/simulation/params/test_gravity.py
@awccoppFC awccoppFC enabled auto-merge (squash) February 18, 2026 15:07
@awccoppFC awccoppFC disabled auto-merge February 18, 2026 15:07
@awccoppFC awccoppFC enabled auto-merge (squash) February 18, 2026 15:08
@awccoppFC awccoppFC merged commit 9ece103 into main Feb 18, 2026
18 checks passed
@awccoppFC awccoppFC deleted the nasser/gravity branch February 18, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants