Skip to content

[FXC-4069] Allow AutomatedFarfield with CustomVolume#1800

Merged
alexxu-flex merged 16 commits intomainfrom
alexxu/custom-vol-auto-farfield
Feb 18, 2026
Merged

[FXC-4069] Allow AutomatedFarfield with CustomVolume#1800
alexxu-flex merged 16 commits intomainfrom
alexxu/custom-vol-auto-farfield

Conversation

@alexxu-flex
Copy link
Copy Markdown
Collaborator

@alexxu-flex alexxu-flex commented Feb 11, 2026

Enables using AutomatedFarfield with CustomVolumes.
The user must define enclosed_surfaces, a list of user-defined patches (not RotationVolumes, etc.) that defines the exterior farfield volume along with the AutomatedFarfield.farfield. Translation turns this into a "farfield" zone, which is then handled on the mesher side.
Validation is updated to enforce enclosed_surfaces iff CustomVolumes. Updated unit tests check this and block "farfield" name collision.

Coming (soon?) in a separate PR: expose _FarfieldBase.zone to the user (requiring enclosed_surfaces with CustomVolumes), and relaxing the restriction on needing to specify a UserDefinedFarfield zone if CustomVolumes are specified.


Note

Medium Risk
Touches meshing parameter validation and JSON translation, which can change accepted configs and the solver/mesher contract; risk is mitigated by added unit tests covering key positive/negative cases.

Overview
Enables using AutomatedFarfield together with CustomVolume zones by introducing AutomatedFarfield.enclosed_surfaces and translating it into an explicit generated "farfield" zone.

Adds cross-field validation to enforce enclosed_surfaces iff CustomVolumes are present, and prevents name collisions by reserving CustomVolume name "farfield" (and disallowing enclosed_surfaces containing a surface named "farfield"). Also loosens the beta-mesher farfield compatibility check to allow automated ("auto") farfield for CustomVolume.

Updates/extends unit tests for both validation and translator output to cover the new workflow and error cases.

Written by Cursor Bugbot for commit 98c527f. This will update automatically on new commits. Configure here.

@alexxu-flex alexxu-flex force-pushed the alexxu/custom-vol-auto-farfield branch from 735dd31 to acb9a32 Compare February 11, 2026 21:46
Comment thread flow360/component/simulation/translator/volume_meshing_translator.py Outdated
Comment thread flow360/component/simulation/meshing_param/params.py Outdated
@alexxu-flex alexxu-flex marked this pull request as draft February 12, 2026 16:28
@alexxu-flex alexxu-flex marked this pull request as ready for review February 12, 2026 19:44
Comment thread flow360/component/simulation/meshing_param/params.py
Comment thread flow360/component/simulation/primitives.py
Comment thread tests/simulation/params/test_validators_params.py Outdated
Comment thread flow360/component/simulation/meshing_param/params.py
Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/meshing_param/params.py
Comment thread flow360/component/simulation/meshing_param/params.py
Comment thread flow360/component/simulation/meshing_param/params.py Outdated
Comment thread flow360/component/simulation/meshing_param/params.py Outdated
Comment thread flow360/component/simulation/meshing_param/volume_params.py
Comment thread flow360/component/simulation/meshing_param/volume_params.py Outdated
Comment thread flow360/component/simulation/meshing_param/params.py
Comment thread flow360/component/simulation/translator/volume_meshing_translator.py Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@alexxu-flex alexxu-flex enabled auto-merge (squash) February 18, 2026 01:34
@alexxu-flex alexxu-flex merged commit 67c77a3 into main Feb 18, 2026
31 of 33 checks passed
@alexxu-flex alexxu-flex deleted the alexxu/custom-vol-auto-farfield branch February 18, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants