[FXC-4069] Allow AutomatedFarfield with CustomVolume#1800
Merged
alexxu-flex merged 16 commits intomainfrom Feb 18, 2026
Merged
Conversation
735dd31 to
acb9a32
Compare
…tom-vol-auto-farfield
…tom-vol-auto-farfield
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
benflexcompute
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables using AutomatedFarfield with CustomVolumes.
The user must define
enclosed_surfaces, a list of user-defined patches (not RotationVolumes, etc.) that defines the exterior farfield volume along with theAutomatedFarfield.farfield. Translation turns this into a "farfield" zone, which is then handled on the mesher side.Validation is updated to enforce enclosed_surfaces iff CustomVolumes. Updated unit tests check this and block "farfield" name collision.
Coming (soon?) in a separate PR: expose _FarfieldBase.zone to the user (requiring enclosed_surfaces with CustomVolumes), and relaxing the restriction on needing to specify a UserDefinedFarfield zone if CustomVolumes are specified.
Note
Medium Risk
Touches meshing parameter validation and JSON translation, which can change accepted configs and the solver/mesher contract; risk is mitigated by added unit tests covering key positive/negative cases.
Overview
Enables using
AutomatedFarfieldtogether withCustomVolumezones by introducingAutomatedFarfield.enclosed_surfacesand translating it into an explicit generated"farfield"zone.Adds cross-field validation to enforce
enclosed_surfacesiff CustomVolumes are present, and prevents name collisions by reservingCustomVolumename"farfield"(and disallowingenclosed_surfacescontaining a surface named"farfield"). Also loosens the beta-mesher farfield compatibility check to allow automated ("auto") farfield forCustomVolume.Updates/extends unit tests for both validation and translator output to cover the new workflow and error cases.
Written by Cursor Bugbot for commit 98c527f. This will update automatically on new commits. Configure here.