Renamed flooding_cell_size to min_passage_size#1811
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
3dd1e40 to
8b85348
Compare
There was a problem hiding this comment.
Pull request overview
This pull request renames the flooding_cell_size parameter to min_passage_size in the meshing configuration. The rename affects the field name, description, validation logic, error messages, and corresponding tests. The new name min_passage_size better reflects that this parameter represents the minimum passage size resolved by the flood-fill exterior classification algorithm, rather than a cell size.
Changes:
- Renamed
flooding_cell_sizefield tomin_passage_sizein theMeshingDefaultsmodel - Updated the field description to clarify it represents "minimum passage size" rather than "minimum cell size"
- Updated validation function and error message to reference the new field name
- Updated all test cases to use the new parameter name
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
flow360/component/simulation/meshing_param/meshing_specs.py |
Renamed field from flooding_cell_size to min_passage_size, updated description and validation logic |
flow360/component/simulation/translator/surface_meshing_translator.py |
Updated whitelist dictionary to include min_passage_size instead of flooding_cell_size |
tests/simulation/params/meshing_validation/test_meshing_param_validation.py |
Updated test function name, docstrings, comments, assertions, and parameter usage to reflect the rename |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Note
Low Risk
Pure parameter rename/validation/translation whitelist update with no algorithmic changes; main risk is backward-compatibility for configs still using
flooding_cell_size.Overview
Renames the Geometry-AI-only meshing default
flooding_cell_sizetomin_passage_size, updates its description to reflect hidden-geometry passage detection semantics, and keeps it gated behindremove_hidden_geometry.Updates GAI surface-meshing JSON filtering/whitelisting to emit
min_passage_size, and adjusts validation/tests to enforce the new field name and error message.Written by Cursor Bugbot for commit a517111. This will update automatically on new commits. Configure here.