[Hotfix Main]: [SNAPPY] Adds an option to ignore region edges in edge refinement#1814
Merged
piotrkluba merged 1 commit intomainfrom Feb 17, 2026
Merged
[Hotfix Main]: [SNAPPY] Adds an option to ignore region edges in edge refinement#1814piotrkluba merged 1 commit intomainfrom
piotrkluba merged 1 commit intomainfrom
Conversation
piotrkluba
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1803 (#1803) to the
mainbranch.Hey @piotrkluba, please review this hotfix PR created from your original PR.
Note
Low Risk
Small, additive change to Snappy edge-refinement parameters and JSON translation, with updated golden-file tests to catch regressions.
Overview
Adds a new
geometric_test_onlyflag to SnappySurfaceEdgeRefinement, allowing edge refinement to ignore region-edge tests and rely only on geometric checks.Plumbs this option through the Snappy surface-meshing translator by emitting
geometricTestOnlyin the generated mesher JSON, and updates translator fixtures/reference JSON plus unit tests to cover both defaultfalseand enabledtruecases.Written by Cursor Bugbot for commit c16c685. This will update automatically on new commits. Configure here.