Skip to content

Comments

[FXC-5592] Results model for (TimeAveraging)ForceDistributionOutput#1817

Merged
piotrkluba merged 12 commits intorelease-candidate/25.8from
piotr/add-missing-results-models
Feb 18, 2026
Merged

[FXC-5592] Results model for (TimeAveraging)ForceDistributionOutput#1817
piotrkluba merged 12 commits intorelease-candidate/25.8from
piotr/add-missing-results-models

Conversation

@piotrkluba
Copy link
Collaborator

@piotrkluba piotrkluba commented Feb 17, 2026

Note

Medium Risk
Touches core results discovery/download plumbing and changes how several existing named-result models are populated, which could affect downloading or indexing of results if filename patterns or lazy population differ.

Overview
Adds a generic NamedResultsCollectionModel for result collections discoverable via filename regex, and migrates MonitorsResultModel, UserDefinedDynamicsResultModel, and CustomForceResultModel to use it.

Introduces ForceDistributionsResultModel + CustomForceDistributionResultCSVModel to load/download per-output *_forceDistribution.csv results (incremental or cumulative, auto-detected by headers), wires it into CaseResults.download(...), and adds SimulationParams.has_force_distributions() / Case.has_force_distributions() gating.

Extends ForceDistributionOutput validation to reject reserved names (X_slicing, Y_slicing), adds new force-distribution field constants, and updates test fixtures/mocks and validators to cover the new result files and name restriction.

Written by Cursor Bugbot for commit 3be7e14. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@piotrkluba piotrkluba merged commit 2283319 into release-candidate/25.8 Feb 18, 2026
18 checks passed
@piotrkluba piotrkluba deleted the piotr/add-missing-results-models branch February 18, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants