[FXC-5592] Results model for (TimeAveraging)ForceDistributionOutput#1817
Merged
piotrkluba merged 12 commits intorelease-candidate/25.8from Feb 18, 2026
Merged
[FXC-5592] Results model for (TimeAveraging)ForceDistributionOutput#1817piotrkluba merged 12 commits intorelease-candidate/25.8from
piotrkluba merged 12 commits intorelease-candidate/25.8from
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
benflexcompute
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core results discovery/download plumbing and changes how several existing named-result models are populated, which could affect downloading or indexing of results if filename patterns or lazy population differ.
Overview
Adds a generic
NamedResultsCollectionModelfor result collections discoverable via filename regex, and migratesMonitorsResultModel,UserDefinedDynamicsResultModel, andCustomForceResultModelto use it.Introduces
ForceDistributionsResultModel+CustomForceDistributionResultCSVModelto load/download per-output*_forceDistribution.csvresults (incremental or cumulative, auto-detected by headers), wires it intoCaseResults.download(...), and addsSimulationParams.has_force_distributions()/Case.has_force_distributions()gating.Extends
ForceDistributionOutputvalidation to reject reserved names (X_slicing,Y_slicing), adds new force-distribution field constants, and updates test fixtures/mocks and validators to cover the new result files and name restriction.Written by Cursor Bugbot for commit 3be7e14. This will update automatically on new commits. Configure here.