Skip to content

FaceGroup Specification of min Passage Size#1826

Merged
NasserFlexCompute merged 3 commits intomainfrom
nasser/faceBasedPassageSize
Feb 22, 2026
Merged

FaceGroup Specification of min Passage Size#1826
NasserFlexCompute merged 3 commits intomainfrom
nasser/faceBasedPassageSize

Conversation

@NasserFlexCompute
Copy link
Copy Markdown
Contributor

@NasserFlexCompute NasserFlexCompute commented Feb 22, 2026

Note

Low Risk
Adds an optional parameter plus a non-fatal validation warning and updates related translator fixtures/tests; no core algorithm changes, but could affect expectations for validation output and serialized meshing configs.

Overview
Adds per-face min_passage_size support to GeometryRefinement, letting callers override the hidden-geometry-removal passage threshold for specific face groups.

Extends meshing validation to emit a warning (not an error) when a per-face min_passage_size is provided but meshing.defaults.remove_hidden_geometry is disabled, since the override would be ignored. Updates translator fixtures/tests to include remove_hidden_geometry: true and to serialize the new min_passage_size field in GAI surface meshing JSON, plus new validation coverage for the warning behavior.

Written by Cursor Bugbot for commit 10e0f41. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings February 22, 2026 02:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for specifying min_passage_size at the face group level through the GeometryRefinement class. This allows users to override the global min_passage_size setting (from MeshingDefaults) for specific face groups, providing finer control over hidden geometry removal resolution.

Changes:

  • Added min_passage_size field to GeometryRefinement class for per-face-group specification
  • Updated test to include min_passage_size parameter in a GeometryRefinement instance
  • Updated reference JSON to reflect the expected serialization format

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
flow360/component/simulation/meshing_param/face_params.py Added min_passage_size as an optional field to GeometryRefinement class with appropriate type hints and description
tests/simulation/translator/test_surface_meshing_translator.py Added test coverage for the new min_passage_size field in a GeometryRefinement refinement
tests/simulation/translator/ref/surface_meshing/gai_surface_mesher.json Updated reference JSON to include the expected serialization of min_passage_size field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread flow360/component/simulation/meshing_param/face_params.py
savithru-flex
savithru-flex previously approved these changes Feb 22, 2026
savithru-flex
savithru-flex previously approved these changes Feb 22, 2026
@NasserFlexCompute NasserFlexCompute merged commit 45a0606 into main Feb 22, 2026
18 checks passed
@NasserFlexCompute NasserFlexCompute deleted the nasser/faceBasedPassageSize branch February 22, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants