FaceGroup Specification of min Passage Size#1826
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for specifying min_passage_size at the face group level through the GeometryRefinement class. This allows users to override the global min_passage_size setting (from MeshingDefaults) for specific face groups, providing finer control over hidden geometry removal resolution.
Changes:
- Added
min_passage_sizefield toGeometryRefinementclass for per-face-group specification - Updated test to include
min_passage_sizeparameter in aGeometryRefinementinstance - Updated reference JSON to reflect the expected serialization format
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flow360/component/simulation/meshing_param/face_params.py | Added min_passage_size as an optional field to GeometryRefinement class with appropriate type hints and description |
| tests/simulation/translator/test_surface_meshing_translator.py | Added test coverage for the new min_passage_size field in a GeometryRefinement refinement |
| tests/simulation/translator/ref/surface_meshing/gai_surface_mesher.json | Updated reference JSON to include the expected serialization of min_passage_size field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Note
Low Risk
Adds an optional parameter plus a non-fatal validation warning and updates related translator fixtures/tests; no core algorithm changes, but could affect expectations for validation output and serialized meshing configs.
Overview
Adds per-face
min_passage_sizesupport toGeometryRefinement, letting callers override the hidden-geometry-removal passage threshold for specific face groups.Extends meshing validation to emit a warning (not an error) when a per-face
min_passage_sizeis provided butmeshing.defaults.remove_hidden_geometryis disabled, since the override would be ignored. Updates translator fixtures/tests to includeremove_hidden_geometry: trueand to serialize the newmin_passage_sizefield in GAI surface meshing JSON, plus new validation coverage for the warning behavior.Written by Cursor Bugbot for commit 10e0f41. This will update automatically on new commits. Configure here.