[FXC-5755] Fix case validation for user defined farfield auto symmetry plane#1827
Merged
benflexcompute merged 13 commits intomainfrom Feb 25, 2026
Merged
[FXC-5755] Fix case validation for user defined farfield auto symmetry plane#1827benflexcompute merged 13 commits intomainfrom
benflexcompute merged 13 commits intomainfrom
Conversation
benflexcompute
approved these changes
Feb 25, 2026
benflexcompute
requested changes
Feb 25, 2026
Collaborator
benflexcompute
left a comment
There was a problem hiding this comment.
Could you take a look at the AI comment?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
benflexcompute
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR 1820 introduced a bug with case validation (see Cursor comment). In validation_simulation_params.py, _collect_asset_boundary_entities would only add "symmetric" boundary to a user-defined farfield when will_generate_forced_symmetry_plane() is True. This did not apply to the "auto" symmetry plane type. This PR changes the behavior to permit an "auto"-like symmetry plane to be detected.
Note
Medium Risk
Touches boundary/ghost-surface validation logic that affects whether surfaces are considered present or deleted, which can change error vs warning behavior and BC completeness outcomes across farfield modes.
Overview
Fixes case validation so a
UserDefinedFarfieldcan use an auto-detected symmetry plane (domain_type=None) when running with Geometry AI + beta mesher.This extends symmetry-plane handling to treat
user-definedfarfields likeautofor surface-deletion checks (via a newgai_and_beta_mesherflag) and ensures thesymmetricghost boundary is included in BC completeness checks for user-defined farfields under those conditions. Tests and surface-mesh fixtures are updated to cover the new path and to assert warnings are empty when valid.Written by Cursor Bugbot for commit 5911a4c. This will update automatically on new commits. Configure here.