Skip to content

[FXC-5755] Fix case validation for user defined farfield auto symmetry plane#1827

Merged
benflexcompute merged 13 commits intomainfrom
sashok/symmPlaneUDF2
Feb 25, 2026
Merged

[FXC-5755] Fix case validation for user defined farfield auto symmetry plane#1827
benflexcompute merged 13 commits intomainfrom
sashok/symmPlaneUDF2

Conversation

@sashok-flex
Copy link
Copy Markdown
Collaborator

@sashok-flex sashok-flex commented Feb 23, 2026

Previous PR 1820 introduced a bug with case validation (see Cursor comment). In validation_simulation_params.py, _collect_asset_boundary_entities would only add "symmetric" boundary to a user-defined farfield when will_generate_forced_symmetry_plane() is True. This did not apply to the "auto" symmetry plane type. This PR changes the behavior to permit an "auto"-like symmetry plane to be detected.


Note

Medium Risk
Touches boundary/ghost-surface validation logic that affects whether surfaces are considered present or deleted, which can change error vs warning behavior and BC completeness outcomes across farfield modes.

Overview
Fixes case validation so a UserDefinedFarfield can use an auto-detected symmetry plane (domain_type=None) when running with Geometry AI + beta mesher.

This extends symmetry-plane handling to treat user-defined farfields like auto for surface-deletion checks (via a new gai_and_beta_mesher flag) and ensures the symmetric ghost boundary is included in BC completeness checks for user-defined farfields under those conditions. Tests and surface-mesh fixtures are updated to cover the new path and to assert warnings are empty when valid.

Written by Cursor Bugbot for commit 5911a4c. This will update automatically on new commits. Configure here.

Comment thread flow360/component/simulation/validation/validation_simulation_params.py Outdated
Comment thread tests/simulation/params/test_automated_farfield.py Outdated
Comment thread flow360/component/simulation/meshing_param/volume_params.py
Comment thread flow360/component/simulation/validation/validation_simulation_params.py Outdated
Copy link
Copy Markdown
Collaborator

@benflexcompute benflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the AI comment?

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread flow360/component/simulation/primitives.py
@benflexcompute benflexcompute enabled auto-merge (squash) February 25, 2026 19:15
@benflexcompute benflexcompute merged commit 028938d into main Feb 25, 2026
5 checks passed
@benflexcompute benflexcompute deleted the sashok/symmPlaneUDF2 branch February 25, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants