[FXC-3870] added reference_velocity for ActuatorDisk power output#1836
Merged
johnmoore4 merged 2 commits intomainfrom Feb 25, 2026
Merged
[FXC-3870] added reference_velocity for ActuatorDisk power output#1836johnmoore4 merged 2 commits intomainfrom
reference_velocity for ActuatorDisk power output#1836johnmoore4 merged 2 commits intomainfrom
Conversation
benflexcompute
changed the title
johnmoore4
force-pushed
the
feature/actuator-disk-reference-velocity
branch
from
361eddf to
c28c0d6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
benflexcompute
changed the title
reference_velocity for ActuatorDisk power output
benflexcompute
previously approved these changes
Feb 24, 2026
johnmoore4
force-pushed
the
feature/actuator-disk-reference-velocity
branch
4 times, most recently
from
459f04f to
1dafeec
Compare
Adds a translate_and_compare test that verifies non-dimensionalization of the referenceVelocity field through the full translation pipeline. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
johnmoore4
force-pushed
the
feature/actuator-disk-reference-velocity
branch
from
1dafeec to
546c04c
Compare
benflexcompute
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added reference_velocity to ActuatorDisk class for use in Power calculations
Ticket: https://flow360.atlassian.net/browse/FXC-3870
Note
Low Risk
Small, additive API/translation change gated behind an optional field; risk is limited to actuator disk JSON output shape when the new parameter is provided.
Overview
Adds an optional
reference_velocityvector to theActuatorDiskmodel to support using a fixed velocity (instead of local flow velocity) when computing actuator disk power output.Updates
actuator_disk_translatorto emitreferenceVelocityin the solver JSON only when the new field is set, and extends the test suite with parameter/model-level unit coverage plus a new golden translation reference (Flow360_actuator_disk_with_ref_velocity.json).Written by Cursor Bugbot for commit 546c04c. This will update automatically on new commits. Configure here.