Skip to content

[FXC-5958] Implements target_surface_node_count for GAI Surf360 and new mesher ref #1837

Merged
mikeparkflex merged 6 commits intomainfrom
mike/target_surface_node_count
Feb 26, 2026
Merged

[FXC-5958] Implements target_surface_node_count for GAI Surf360 and new mesher ref #1837
mikeparkflex merged 6 commits intomainfrom
mike/target_surface_node_count

Conversation

@mikeparkflex
Copy link
Copy Markdown
Contributor

@mikeparkflex mikeparkflex commented Feb 24, 2026

implements the "target_surface_node_count" json option which can be set by the client


Note

Medium Risk
Touches meshing parameter validation and JSON translation, which can change generated mesher configs and fail existing workflows if clients set the new field outside Geometry AI mode.

Overview
Adds a new meshing.defaults.target_surface_node_count option to target an approximate surface mesh node count, gated to Geometry AI via contextual validation.

Updates the GAI surface-meshing JSON filtering whitelist so the field is emitted only when set, and adds translator tests covering GAI pass-through/absence plus rejection in legacy (non-GAI) validation.

Written by Cursor Bugbot for commit fc27b2d. This will update automatically on new commits. Configure here.

Comment thread flow360/component/simulation/translator/surface_meshing_translator.py Outdated
Comment thread flow360/component/simulation/meshing_param/meshing_specs.py
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread tests/simulation/translator/test_surface_meshing_translator.py
@flexcompute flexcompute deleted a comment from mikeparkflex Feb 24, 2026
@mikeparkflex mikeparkflex force-pushed the mike/target_surface_node_count branch from e5c656a to f300d9c Compare February 25, 2026 15:00
@benflexcompute
Copy link
Copy Markdown
Collaborator

Is there a ticket number for this?

Comment thread flow360/component/simulation/meshing_param/meshing_specs.py Outdated
@mikeparkflex mikeparkflex force-pushed the mike/target_surface_node_count branch from 4a9e5c9 to 085c2a6 Compare February 25, 2026 20:54
@mikeparkflex
Copy link
Copy Markdown
Contributor Author

Is there a ticket number for this?

I'm using the todo list in https://flow360.atlassian.net/browse/FXC-5879 I created a child for bookkeeping https://flow360.atlassian.net/browse/FXC-5958

@benflexcompute benflexcompute changed the title implements target_surface_node_count for GAI Surf360 and new mesher ref FXC-5958] Implements target_surface_node_count for GAI Surf360 and new mesher ref Feb 26, 2026
@benflexcompute benflexcompute changed the title FXC-5958] Implements target_surface_node_count for GAI Surf360 and new mesher ref [FXC-5958] Implements target_surface_node_count for GAI Surf360 and new mesher ref Feb 26, 2026
@mikeparkflex mikeparkflex merged commit 13f6c35 into main Feb 26, 2026
19 checks passed
@mikeparkflex mikeparkflex deleted the mike/target_surface_node_count branch February 26, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants