[FXC-5794] Fix validation for AutomatedFarfield + enclosed surfaces + CustomZones#1844
Merged
benflexcompute merged 4 commits intomainfrom Feb 26, 2026
Merged
[FXC-5794] Fix validation for AutomatedFarfield + enclosed surfaces + CustomZones#1844benflexcompute merged 4 commits intomainfrom
AutomatedFarfield + enclosed surfaces + CustomZones#1844benflexcompute merged 4 commits intomainfrom
Conversation
… CustomZones Relax BC completeness check and PorousJump interface validation for dual-belonging surfaces (faces in both AutomatedFarfield.enclosed_surfaces and CustomVolume.boundaries) that form farfield-custom-volume zone interfaces. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ceca76184
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax BC completeness check and PorousJump interface validation for dual-belonging surfaces (faces in both AutomatedFarfield.enclosed_surfaces and CustomVolume.boundaries) that form farfield-custom-volume zone interfaces.
Note
Medium Risk
Changes parameter validation behavior around boundary completeness and
PorousJumpinterface checks, which could allow previously-invalid setups and affect error/warning reporting. Scope is limited to validation logic and is covered by new unit tests.Overview
Relaxes validation for configurations where a surface is dual-belonging (listed in
AutomatedFarfield.enclosed_surfacesand also on aCustomVolumeboundary), treating these as expected farfield–custom-volume interfaces.ParamsValidationInfonow extracts/expandsenclosed_surfaces(including selector expansion), computes the dual-belonging surface IDs, and both the BC completeness check andPorousJumpvalidator skip interface requirements for these specific cross-zone pairs. Adds focused tests covering selector expansion, interface-name collection for completeness validation, and the updatedPorousJumpbehavior.Written by Cursor Bugbot for commit f6fcc39. This will update automatically on new commits. Configure here.