[SNAPPY] Enable only selected shapes of UniformRefinement#1846
Merged
piotrkluba merged 13 commits intomainfrom Mar 16, 2026
Merged
[SNAPPY] Enable only selected shapes of UniformRefinement#1846piotrkluba merged 13 commits intomainfrom
piotrkluba merged 13 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
benflexcompute
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Adds new snappy-specific validation rules for
UniformRefinement(including volume refinements projected to the surface) and extends translation coverage to include spherical refinement volumes; may reject previously-accepted inputs or change validation timing for snappy workflows.Overview
Tightens snappyHexMesh support for
UniformRefinementby enforcing shape and parameter restrictions: onlyBox/Cylinder/Sphereentities are allowed in snappy contexts, and projected refinements now reject rotated boxes and hollow cylinders (shared viavalidate_snappy_uniform_refinement_entities).Extends validation to cover
VolumeMeshingParamsrefinements whenproject_to_surfaceis enabled (or defaulted) so volume-side refinements that affect the surface mesh are checked consistently. Updates tests and translator fixtures to coverSphere-based coupled refinements, including a new reference JSON.Written by Cursor Bugbot for commit 136cd9a. This will update automatically on new commits. Configure here.