Skip to content

[SNAPPY] Enable only selected shapes of UniformRefinement#1846

Merged
piotrkluba merged 13 commits intomainfrom
piotr/uniform-refinements-restrictions-snappy
Mar 16, 2026
Merged

[SNAPPY] Enable only selected shapes of UniformRefinement#1846
piotrkluba merged 13 commits intomainfrom
piotr/uniform-refinements-restrictions-snappy

Conversation

@piotrkluba
Copy link
Copy Markdown
Collaborator

@piotrkluba piotrkluba commented Feb 26, 2026

Note

Medium Risk
Adds new snappy-specific validation rules for UniformRefinement (including volume refinements projected to the surface) and extends translation coverage to include spherical refinement volumes; may reject previously-accepted inputs or change validation timing for snappy workflows.

Overview
Tightens snappyHexMesh support for UniformRefinement by enforcing shape and parameter restrictions: only Box/Cylinder/Sphere entities are allowed in snappy contexts, and projected refinements now reject rotated boxes and hollow cylinders (shared via validate_snappy_uniform_refinement_entities).

Extends validation to cover VolumeMeshingParams refinements when project_to_surface is enabled (or defaulted) so volume-side refinements that affect the surface mesh are checked consistently. Updates tests and translator fixtures to cover Sphere-based coupled refinements, including a new reference JSON.

Written by Cursor Bugbot for commit 136cd9a. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread flow360/component/simulation/meshing_param/meshing_validators.py Outdated
@piotrkluba piotrkluba enabled auto-merge (squash) March 16, 2026 15:45
@piotrkluba piotrkluba merged commit 1e4a444 into main Mar 16, 2026
20 checks passed
@piotrkluba piotrkluba deleted the piotr/uniform-refinements-restrictions-snappy branch March 16, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants