change linear solver updater to 25.9.1#1851
Merged
Conversation
benflexcompute
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adjusts version-migration behavior for
SimulationParamsby introducing a new milestone; incorrect migration could break loading/validation of older JSONs that omit the linear solver discriminator.Overview
Adds a new
25.9.1migration step that populates missingtype_name: "LinearSolver"undermodels[*].navier_stokes_solver.linear_solver, and registers it inVERSION_MILESTONESso the mainupdater()can move25.9.0 -> 25.9.1.Updates
_to_25_9_0to stop after removing the deprecated meshing key and migrating wall-function booleans, and adds unit tests covering the new updater function, end-to-end update path, and no-modelsedge cases.Written by Cursor Bugbot for commit 834760a. This will update automatically on new commits. Configure here.