[FXC-5213] Add vtkhdf as valid output_format option for transient output#1878
Merged
benflexcompute merged 14 commits intodevelopfrom Mar 11, 2026
Merged
[FXC-5213] Add vtkhdf as valid output_format option for transient output#1878benflexcompute merged 14 commits intodevelopfrom
benflexcompute merged 14 commits intodevelopfrom
Conversation
awccoppFC
requested review from
NasserFlexCompute,
andrzej-krupka and
benflexcompute
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
…vert - Move output_format string-to-list migration from 25.9.2 to 25.10.0 - Trim _LegacyOutputFormatStrings to only paraview, tecplot, both - Deduplicate list entries in _normalize_output_format validator - Sort output_format list before joining in solver translator for determinism - Simplify output_format field description - Revert v1 flow360_output.py changes (out of scope) - Update tests to target 25.10.0 milestone
benflexcompute
changed the title
…translator - Show correctly stripped/sorted values in deprecation warning for comma-separated output_format - Sort and deduplicate comma-separated values in migration to match validator behavior - Remove unreachable dead code in translator now that validator guarantees list type
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
benflexcompute
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds VTK-HDF output file support
Note
Medium Risk
Changes the public output schema from a single
output_formatstring to a normalized list and updates solver translation/migrations accordingly, which can affect serialization and downstream solver JSON for all output types.Overview
Adds support for additional output formats (
vtkhdf,ensight) by changingoutput_formatfrom a single string (including legacy"both") to a normalized list of formats with deprecation warnings for legacy string usage.Introduces a
25.10.0params updater to migrate existing JSONs ("both", comma-separated strings, or bare strings) into list form, updates solver translation to emit a comma-joinedoutputFormat, and refreshes reference fixtures/tests to expect list-basedoutput_formatplus new normalization/deduplication coverage.Written by Cursor Bugbot for commit d443dda. This will update automatically on new commits. Configure here.