Skip to content

Added warning for multi-zone GAI cases with remove_hidden_geometry = True#1896

Merged
savithru-flex merged 5 commits intomainfrom
savithru/warningMultiZoneRemoveHiddenGeometry
Mar 14, 2026
Merged

Added warning for multi-zone GAI cases with remove_hidden_geometry = True#1896
savithru-flex merged 5 commits intomainfrom
savithru/warningMultiZoneRemoveHiddenGeometry

Conversation

@savithru-flex
Copy link
Copy Markdown
Contributor

@savithru-flex savithru-flex commented Mar 14, 2026

Added warning for multi-zone GAI cases with remove_hidden_geometry = True since it's not fully supported


Note

Medium Risk
Adds new validation warnings and slightly changes GAI surface-meshing JSON filtering to include CustomZones, which can affect meshing inputs for some multi-zone configurations.

Overview
Adds a new post-validation warning when defaults.remove_hidden_geometry=True is used alongside multiple effective volume zones (multiple CustomVolumes and/or an AutomatedFarfield/WindTunnelFarfield), since hidden-geometry removal is not fully supported for multi-zone cases.

Updates the GAI surface-meshing translator filter to pass through CustomZones in volume_zones, and adds comprehensive tests covering warning/no-warning scenarios (including UserDefinedFarfield not counting toward the zone total).

Written by Cursor Bugbot for commit bc9617f. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread flow360/component/simulation/meshing_param/params.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a validation warning for Geometry AI meshing configurations where remove_hidden_geometry=True is used in multi-zone setups, since that combination isn’t fully supported.

Changes:

  • Added a MeshingParams validator to warn when remove_hidden_geometry=True is combined with multiple farfield/custom-zone configurations.
  • Updated GAI surface meshing JSON filtering to include CustomZones in the translated volume_zones.
  • Added tests covering warning/no-warning cases for the new validation behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
flow360/component/simulation/meshing_param/params.py Adds the new multi-zone + remove_hidden_geometry validation warning.
flow360/component/simulation/translator/surface_meshing_translator.py Includes CustomZones in the filtered volume_zones passed to GAI surface meshing translation.
tests/simulation/params/meshing_validation/test_meshing_param_validation.py Adds unit tests validating the warning behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread flow360/component/simulation/meshing_param/params.py Outdated
@savithru-flex savithru-flex enabled auto-merge (squash) March 14, 2026 05:38
@savithru-flex savithru-flex merged commit 9392f2c into main Mar 14, 2026
20 checks passed
@savithru-flex savithru-flex deleted the savithru/warningMultiZoneRemoveHiddenGeometry branch March 14, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants