Added warning for multi-zone GAI cases with remove_hidden_geometry = True#1896
Merged
savithru-flex merged 5 commits intomainfrom Mar 14, 2026
Merged
Conversation
…, since it's not fully supported.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a validation warning for Geometry AI meshing configurations where remove_hidden_geometry=True is used in multi-zone setups, since that combination isn’t fully supported.
Changes:
- Added a
MeshingParamsvalidator to warn whenremove_hidden_geometry=Trueis combined with multiple farfield/custom-zone configurations. - Updated GAI surface meshing JSON filtering to include
CustomZonesin the translatedvolume_zones. - Added tests covering warning/no-warning cases for the new validation behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
flow360/component/simulation/meshing_param/params.py |
Adds the new multi-zone + remove_hidden_geometry validation warning. |
flow360/component/simulation/translator/surface_meshing_translator.py |
Includes CustomZones in the filtered volume_zones passed to GAI surface meshing translation. |
tests/simulation/params/meshing_validation/test_meshing_param_validation.py |
Adds unit tests validating the warning behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
benflexcompute
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added warning for multi-zone GAI cases with remove_hidden_geometry = True since it's not fully supported
Note
Medium Risk
Adds new validation warnings and slightly changes GAI surface-meshing JSON filtering to include
CustomZones, which can affect meshing inputs for some multi-zone configurations.Overview
Adds a new post-validation warning when
defaults.remove_hidden_geometry=Trueis used alongside multiple effective volume zones (multipleCustomVolumes and/or anAutomatedFarfield/WindTunnelFarfield), since hidden-geometry removal is not fully supported for multi-zone cases.Updates the GAI surface-meshing translator filter to pass through
CustomZonesinvolume_zones, and adds comprehensive tests covering warning/no-warning scenarios (includingUserDefinedFarfieldnot counting toward the zone total).Written by Cursor Bugbot for commit bc9617f. This will update automatically on new commits. Configure here.