Skip to content

[doctrings]: clarification for initial blade direction#1916

Merged
marcvivesmassana merged 2 commits intomainfrom
marc/initial_blade_direction
Mar 20, 2026
Merged

[doctrings]: clarification for initial blade direction#1916
marcvivesmassana merged 2 commits intomainfrom
marc/initial_blade_direction

Conversation

@marcvivesmassana
Copy link
Collaborator

@marcvivesmassana marcvivesmassana commented Mar 20, 2026

Note

Low Risk
Docstring-only changes clarifying how BETDisk.initial_blade_direction should be interpreted; no runtime logic or validation behavior is modified.

Overview
Clarifies the meaning and requirements of BETDisk.initial_blade_direction in volume_models.py, explicitly stating it is a global mesh-frame direction (not a disk-local frame), must be orthogonal to Cylinder.axis, and is required for unsteady BET Line when blade_line_chord > 0.

Updates the corresponding parameter docs in the BETDisk constructors to match this clarified definition.

Written by Cursor Bugbot for commit 7a4fc1a. This will update automatically on new commits. Configure here.

@marcvivesmassana marcvivesmassana merged commit a79e6aa into main Mar 20, 2026
20 checks passed
@marcvivesmassana marcvivesmassana deleted the marc/initial_blade_direction branch March 20, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants