Skip to content

[Hotfix Main]: fix: update default solver version to release-25.9 #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benflexcompute merged 3 commits into from
Mar 25, 2026
Merged

[Hotfix Main]: fix: update default solver version to release-25.9 #1926

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0e01d4
fix: update default solver version to release-25.9 (#1924)
benflexcompute Mar 23, 2026
8577286
Merge branch 'main' into hotfix-main-pr1924
benflexcompute Mar 23, 2026
28a00ce
fix linter error and formatting.
benflexcompute Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion tests/simulation/test_updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from flow360.component.simulation.framework.updater_utils import Flow360Version
from flow360.component.simulation.services import ValidationCalledBy, validate_model
from flow360.component.simulation.validation.validation_context import ALL
from flow360.version import __version__
from flow360.version import __solver_version__, __version__


@pytest.fixture(autouse=True)
Expand All @@ -45,6 +45,18 @@ def test_version_consistency():
)


def test_default_solver_version_matches_module_version():
"""For non-beta releases (vA.B.C), the default solver version must be 'release-A.B'."""
version = Flow360Version(__version__)
if re.search(r"b\d+$", __version__):
pytest.skip("Beta version, skipping solver version check")
expected_solver_version = f"release-{version.major}.{version.minor}"
assert __solver_version__ == expected_solver_version, (
f"Default solver version mismatch: __solver_version__ is '{__solver_version__}', "
f"but expected '{expected_solver_version}' based on __version__ '{__version__}'"
)


def test_version_greater_than_highest_updater_version():
current_python_version = Flow360Version(__version__)
assert (
Expand Down
Loading