refactor(flow360): use unified Flow360BaseModel from schema package#1943
Merged
benflexcompute merged 2 commits intoBenY/CentralizedSchemafrom Mar 30, 2026
Merged
refactor(flow360): use unified Flow360BaseModel from schema package#1943benflexcompute merged 2 commits intoBenY/CentralizedSchemafrom
benflexcompute merged 2 commits intoBenY/CentralizedSchemafrom
Conversation
Client's Flow360BaseModel is now a re-export from flow360-schema. All SDK methods (copy, preprocess, file I/O, hash, help) live in schema. - Remove ~420 lines of duplicated base model code - Drop YAML file support (JSON only) - Update tests to remove YAML test cases Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benflexcompute
force-pushed
the
BenY/BaseModelMigration
branch
from
62f1ee5 to
8c73139
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Coverage report (flow360)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
benflexcompute
force-pushed
the
BenY/BaseModelMigration
branch
from
d67d312 to
593a974
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
… version - Remove unused re-exports of _preprocess_any_model, _preprocess_nested_list, need_conversion (only used internally by schema) - Bump flow360-schema minimum version to ~0.1.17 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benflexcompute
force-pushed
the
BenY/BaseModelMigration
branch
from
593a974 to
b980e6e
Compare
angranl-flex
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flow360BaseModelis now a pure re-export fromflow360-schemaDepends on: flexcompute/flex PR (flow360-schema BaseModel unification)
Test plan
pytest tests/simulation— 1026 passedpytest --ignore=tests/simulation— 341 passedpylintclean on changed files🤖 Generated with Claude Code
Note
Medium Risk
Moderate risk because it centralizes core model behavior (copy/preprocess/file I/O/hash) into the
flow360-schemadependency and removes YAML serialization paths, which could affect downstream workflows relying on prior SDK-specific behavior.Overview
Unifies the client’s base model with the schema package.
flow360.component.simulation.framework.base_model.Flow360BaseModelis reduced to a pure re-export offlow360_schema.framework.base_model.Flow360BaseModel, deleting the local implementations forcopy,preprocess, hashing, and JSON/YAML file I/O.Updates dependency + tests for the new behavior. Bumps
flow360-schemato0.1.17and adjusts tests to only round-trip via.json(removing.yamlcoverage and YAML imports).Written by Cursor Bugbot for commit b980e6e. This will update automatically on new commits. Configure here.