refactor(flow360): entity system — client files become re-import relays#1945
Merged
benflexcompute merged 10 commits intoBenY/CentralizedSchemafrom Mar 31, 2026
Merged
refactor(flow360): entity system — client files become re-import relays#1945benflexcompute merged 10 commits intoBenY/CentralizedSchemafrom
benflexcompute merged 10 commits intoBenY/CentralizedSchemafrom
Conversation
Client entity modules now re-export from flow360_schema: - entity_info, entity_operation, entity_base, entity_selector - entity_registry, entity_materializer, entity_utils, entity_expansion_utils - multi_constructor_model_base, unique_list - primitives, output_entities, utils (model_attribute_unlock, BoundingBoxType) - types (Axis, Vector), exceptions (Flow360ValueError, Flow360DeprecationError) All 159 importing files continue to work via relay. Relay removal will be done in a separate PR after all migrations complete. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8775dcf8bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Contributor
Coverage report (flow360)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
angranl-flex
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
_get_draft_entity_type_namesto handletypes.UnionType(Python 3.10+X | Ysyntax)LengthTypeimport in geometry.py — use newLength.PositiveFloat64from schemaDepends on: flexcompute/flex entity migration PR (schema side)
Test plan
pytest tests/simulation— 1074 passedpylintclean on all relay files (10/10)🤖 Generated with Claude Code
Note
Medium Risk
Medium risk due to broad refactor across core simulation/entity plumbing and materialization/selector code paths, even though behavior is intended to be preserved via re-exports. Main risk is subtle import/typing/serialization regressions when validating or expanding entities from params dicts.
Overview
Refactors the SDK’s simulation/entity framework to delegate implementations to
flow360_schema. Several core modules (entity_info,entity_operation,entity_base,entity_registry,entity_selector,entity_utils,unique_list,output_entities, plus materialization/context helpers) are replaced with thin re-export relays to keep existing import paths working.Updates internal mutation patterns by removing
model_attribute_unlockusage and switching to_force_set_attrwhen updating frozen/private fields (e.g., entity renames, asset-cache setup, boundary full-name assignment, imported surface caching). Also simplifies entity materialization by wrapping the schema’smaterialize_entities_and_selectors_in_placewhile retaining the client-specific entity type map/builder.Written by Cursor Bugbot for commit f275a42. This will update automatically on new commits. Configure here.