schema: remove duplicated client entity tests#1954
Merged
benflexcompute merged 1 commit intoBenY/CentralizedSchemafrom Apr 3, 2026
Merged
schema: remove duplicated client entity tests#1954benflexcompute merged 1 commit intoBenY/CentralizedSchemafrom
benflexcompute merged 1 commit intoBenY/CentralizedSchemafrom
Conversation
Contributor
angranl-flex
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This removes the pure entity unit tests that were migrated into
flow360-schemaand trims the remaining client-side test files down to the integration boundaries the client still owns.The client test surface now keeps coverage for:
Why
After the entity migration, keeping the old pure entity tests in the Python client created duplicated coverage and unclear ownership across repos.
This PR makes the split explicit: schema owns pure entity unit tests, while the client keeps only client-specific integration coverage.
Impact
Root cause
The implementation moved before the unit-test ownership did, so both repos were still testing the same entity behavior.
Validation
PYTHONNOUSERSITE=1 PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /disk2/ben/SchemaMigration/Flow360/.venv/bin/python3 -m pytest -c tests/pytest.ini -rA -o cache_dir=tests/.pytest_cache tests/simulation/framework/test_entities_v2.py tests/simulation/framework/test_entities_fast_register.py tests/simulation/framework/test_entity_dict_database.py tests/simulation/framework/test_entity_list.py tests/simulation/framework/test_entity_type_filtering_during_expansion.py tests/simulation/framework/test_multi_constructor_model.py tests/simulation/framework/test_pre_deserialized_entity_info.pyResult used for this change set:
16 passed.Note
Low Risk
Low risk: changes are test-only and primarily delete duplicated unit coverage, with remaining tests still exercising key client-side integration boundaries (registry extraction, asset traversal, draft selector preview). Potential risk is reduced regression detection if schema-side coverage diverges from client behavior.
Overview
Removes a large set of duplicated entity/selector/materializer/expansion tests from the Python client (including deleting several test modules) now that pure entity behavior is owned by
flow360-schema.Refactors the remaining framework tests to focus on client-owned boundaries: entity registry extraction/parity via
get_registry_from_params()/get_entity_info_and_registry_from_dict(), asset__getitem__traversal behavior, draft selector preview (including mirrored entities), and a narrowed multi-constructor test that only validates non-entity input-cache mutation.Written by Cursor Bugbot for commit 642e268. This will update automatically on new commits. Configure here.