Skip to content

schema: remove duplicated client entity tests#1954

Merged
benflexcompute merged 1 commit intoBenY/CentralizedSchemafrom
codex/entity-test-migration
Apr 3, 2026
Merged

schema: remove duplicated client entity tests#1954
benflexcompute merged 1 commit intoBenY/CentralizedSchemafrom
codex/entity-test-migration

Conversation

@benflexcompute
Copy link
Copy Markdown
Collaborator

@benflexcompute benflexcompute commented Apr 2, 2026

What changed

This removes the pure entity unit tests that were migrated into flow360-schema and trims the remaining client-side test files down to the integration boundaries the client still owns.

The client test surface now keeps coverage for:

  • asset and params traversal behavior
  • registry extraction and parity from client params
  • draft selector preview behavior
  • mirrored entity preview behavior
  • non-entity multi-constructor coverage

Why

After the entity migration, keeping the old pure entity tests in the Python client created duplicated coverage and unclear ownership across repos.

This PR makes the split explicit: schema owns pure entity unit tests, while the client keeps only client-specific integration coverage.

Impact

  • duplicated selector/materializer/entity-info/entity-expansion tests are removed from the client
  • remaining client tests are smaller and focused on orchestration boundaries
  • the client and schema repos now have a clearer testing contract for entity behavior

Root cause

The implementation moved before the unit-test ownership did, so both repos were still testing the same entity behavior.

Validation

  • PYTHONNOUSERSITE=1 PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /disk2/ben/SchemaMigration/Flow360/.venv/bin/python3 -m pytest -c tests/pytest.ini -rA -o cache_dir=tests/.pytest_cache tests/simulation/framework/test_entities_v2.py tests/simulation/framework/test_entities_fast_register.py tests/simulation/framework/test_entity_dict_database.py tests/simulation/framework/test_entity_list.py tests/simulation/framework/test_entity_type_filtering_during_expansion.py tests/simulation/framework/test_multi_constructor_model.py tests/simulation/framework/test_pre_deserialized_entity_info.py

Result used for this change set: 16 passed.


Note

Low Risk
Low risk: changes are test-only and primarily delete duplicated unit coverage, with remaining tests still exercising key client-side integration boundaries (registry extraction, asset traversal, draft selector preview). Potential risk is reduced regression detection if schema-side coverage diverges from client behavior.

Overview
Removes a large set of duplicated entity/selector/materializer/expansion tests from the Python client (including deleting several test modules) now that pure entity behavior is owned by flow360-schema.

Refactors the remaining framework tests to focus on client-owned boundaries: entity registry extraction/parity via get_registry_from_params()/get_entity_info_and_registry_from_dict(), asset __getitem__ traversal behavior, draft selector preview (including mirrored entities), and a narrowed multi-constructor test that only validates non-entity input-cache mutation.

Written by Cursor Bugbot for commit 642e268. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Coverage report (flow360)

This PR does not seem to contain any modification to coverable code.

@benflexcompute benflexcompute marked this pull request as ready for review April 3, 2026 15:03
@benflexcompute benflexcompute changed the title [codex] remove duplicated client entity tests schema: remove duplicated client entity tests Apr 3, 2026
@benflexcompute benflexcompute merged commit 6565610 into BenY/CentralizedSchema Apr 3, 2026
35 checks passed
@benflexcompute benflexcompute deleted the codex/entity-test-migration branch April 3, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants