[Hotfix Main]: fix(): Fix coordinate transformation writes to frozen BETDisk fields#1980
Merged
Conversation
benflexcompute
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1979 (#1979) to the
mainbranch.Hey @benflexcompute, please review this hotfix PR created from your original PR.
Note
Medium Risk
Changes the coordinate-system transformation traversal to only reassign
list/tuplefields when an element actually changes, which could subtly affect any models relying on the previous always-copy behavior. Scope is limited to preprocessing/translation but runs across many param types.Overview
Prevents
apply_coordinate_system_transformationsfrom blindly recreating and reassigning everylist/tuplefield during recursion; it now only copies andsetattrs the sequence when at least one element is transformed (e.g., anEntityBasereplacement).Adds a regression test covering a
BETDiskwith coordinate-system-assigned entities to ensure the entity is transformed while unrelated (potentially frozen) numeric/parameter sequences likemach_numbers,twists, andchordsare left untouched.Reviewed by Cursor Bugbot for commit 311f217. Bugbot is set up for automated code reviews on this repo. Configure here.