Skip to content

[Hotfix Main]: fix(): Fix coordinate transformation writes to frozen BETDisk fields#1980

Merged
benflexcompute merged 1 commit into
mainfrom
hotfix-main-pr1979
Apr 9, 2026
Merged

[Hotfix Main]: fix(): Fix coordinate transformation writes to frozen BETDisk fields#1980
benflexcompute merged 1 commit into
mainfrom
hotfix-main-pr1979

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 9, 2026

Hotfix of PR #1979 (#1979) to the main branch.
Hey @benflexcompute, please review this hotfix PR created from your original PR.


Note

Medium Risk
Changes the coordinate-system transformation traversal to only reassign list/tuple fields when an element actually changes, which could subtly affect any models relying on the previous always-copy behavior. Scope is limited to preprocessing/translation but runs across many param types.

Overview
Prevents apply_coordinate_system_transformations from blindly recreating and reassigning every list/tuple field during recursion; it now only copies and setattrs the sequence when at least one element is transformed (e.g., an EntityBase replacement).

Adds a regression test covering a BETDisk with coordinate-system-assigned entities to ensure the entity is transformed while unrelated (potentially frozen) numeric/parameter sequences like mach_numbers, twists, and chords are left untouched.

Reviewed by Cursor Bugbot for commit 311f217. Bugbot is set up for automated code reviews on this repo. Configure here.

@benflexcompute benflexcompute marked this pull request as ready for review April 9, 2026 18:44
@benflexcompute benflexcompute enabled auto-merge (squash) April 9, 2026 18:44
@benflexcompute benflexcompute merged commit 0ad7d49 into main Apr 9, 2026
18 checks passed
@benflexcompute benflexcompute deleted the hotfix-main-pr1979 branch April 9, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant