Skip to content

[Hotfix 25.9]: fix(): Fix coordinate transformation writes to frozen BETDisk fields#1981

Merged
benflexcompute merged 1 commit into
release-candidate/25.9from
hotfix-release-candidate-25.9-pr1979
Apr 9, 2026
Merged

[Hotfix 25.9]: fix(): Fix coordinate transformation writes to frozen BETDisk fields#1981
benflexcompute merged 1 commit into
release-candidate/25.9from
hotfix-release-candidate-25.9-pr1979

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 9, 2026

Hotfix of PR #1979 (#1979) to the release-candidate/25.9 branch.
Hey @benflexcompute, please review this hotfix PR created from your original PR.


Note

Medium Risk
Touches recursive coordinate-system transformation logic used during translation; while behavior should be equivalent, conditional mutation could affect edge cases where callers relied on always reassigning list/tuple fields.

Overview
Fixes apply_coordinate_system_transformations to avoid reassigning list/tuple fields unless at least one element actually changes, preventing writes to frozen non-entity sequences (e.g., BETDisk numeric arrays) during coordinate-system expansion.

Adds a regression test covering a BETDisk with coordinate-system-assigned entities, asserting the entity is transformed while unrelated frozen sequence fields (mach_numbers, twists, chords) remain unchanged.

Reviewed by Cursor Bugbot for commit 2a07eea. Bugbot is set up for automated code reviews on this repo. Configure here.

@benflexcompute benflexcompute marked this pull request as ready for review April 9, 2026 18:44
@benflexcompute benflexcompute enabled auto-merge (squash) April 9, 2026 18:45
@benflexcompute benflexcompute merged commit 0041cbb into release-candidate/25.9 Apr 9, 2026
18 checks passed
@benflexcompute benflexcompute deleted the hotfix-release-candidate-25.9-pr1979 branch April 9, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant