[Hotfix 25.9]: fix(): Fix coordinate transformation writes to frozen BETDisk fields#1981
Merged
benflexcompute merged 1 commit intoApr 9, 2026
Conversation
benflexcompute
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1979 (#1979) to the
release-candidate/25.9branch.Hey @benflexcompute, please review this hotfix PR created from your original PR.
Note
Medium Risk
Touches recursive coordinate-system transformation logic used during translation; while behavior should be equivalent, conditional mutation could affect edge cases where callers relied on always reassigning list/tuple fields.
Overview
Fixes
apply_coordinate_system_transformationsto avoid reassigning list/tuple fields unless at least one element actually changes, preventing writes to frozen non-entity sequences (e.g., BETDisk numeric arrays) during coordinate-system expansion.Adds a regression test covering a
BETDiskwith coordinate-system-assigned entities, asserting the entity is transformed while unrelated frozen sequence fields (mach_numbers,twists,chords) remain unchanged.Reviewed by Cursor Bugbot for commit 2a07eea. Bugbot is set up for automated code reviews on this repo. Configure here.