Migrate SimulationParams models to flow360-schema#1989
Merged
benflexcompute merged 9 commits intoBenY/CentralizedSchemafrom Apr 14, 2026
Merged
Migrate SimulationParams models to flow360-schema#1989benflexcompute merged 9 commits intoBenY/CentralizedSchemafrom
benflexcompute merged 9 commits intoBenY/CentralizedSchemafrom
Conversation
…Y/simulation-schema-migration-wip
angranl-flex
approved these changes
Apr 14, 2026
Contributor
Coverage report (flow360)Click to see where and how coverage changed
The report is truncated to 25 files out of 33. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimulationParams -> leaf modelsimports from the Python client toflow360-schemaNotes
Validation
poetry run pylint $(git ls-files "flow360/*.py") --rcfile .pylintrcexport PYTEST_CACHE_DIR="./tests/.pytest_cache" && poetry run pytest -c tests/pytest.ini -rA tests/simulationNote
Medium Risk
Medium risk because many simulation/meshing/material model definitions and validators are replaced with schema re-exports, so any schema/client version mismatch or subtle import/validation differences could break user code at runtime.
Overview
Migrates the Python client’s simulation model source-of-truth to
flow360-schemaby replacing local implementations of boundary split helpers, meshing parameter models (edge/face/volume/snappy/specs/params), and material models with thin relay modules that re-export the schema types under the existing client import paths.Updates validation wiring to match the new ownership (e.g.,
meshing_validatorsnow lazily resolvesvalidate_snappy_uniform_refinement_entitiesfrom the schema), while keeping the public API surface largely stable for downstream imports.Reviewed by Cursor Bugbot for commit ee7e4ba. Bugbot is set up for automated code reviews on this repo. Configure here.