[FXC-6076] Plumb rotor_disk_names into Custom Volume and Farfield Zone Translation#2028
Merged
shreyas-flex merged 3 commits intorelease-candidate/25.9from May 4, 2026
Conversation
benflexcompute
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Plumb
rotor_disk_namesinto Custom Volume and Farfield Zone TranslationFXC: https://flow360.atlassian.net/browse/FXC-6076
Summary
_get_custom_volumesand_build_farfield_zonewere calling_translate_enclosed_entity_namewithoutrotor_disk_names, causing anyCylinderentity in aCustomVolume.bounding_entitiesto always translate to"slidingInterface-<name>"-- even when it's actually a rotor disk (defined viaAxisymmetricRefinement). This made the companion C++ fix inVolumeMultiZoneUtils.hunreachable, since the patch name mismatch ("slidingInterface-foo"vs"rotorDisk-foo") prevented the custom zone exclusion logic from working.Changes
flow360/component/simulation/translator/volume_meshing_translator.py_build_farfield_zone(volume_zones)->_build_farfield_zone(volume_zones, rotor_disk_names=None): forwards to_translate_enclosed_entity_nameso that rotor-disk cylinders in farfieldenclosed_entitiesget the"rotorDisk-"prefix._get_custom_volumes(volume_zones)->_get_custom_volumes(volume_zones, rotor_disk_names=None): forwards to_translate_enclosed_entity_nameso that rotor-disk cylinders inCustomVolume.bounding_entitiesget the"rotorDisk-"prefix.get_volume_meshing_jsonnow pass the already-computedrotor_disk_nameslist.tests/simulation/translator/test_volume_meshing_translator.pyAdded
test_custom_volume_with_rotor_disk_cylinderwhich verifies that when aCylinderis used as anAxisymmetricRefinementand also placed inside aCustomVolume, both the custom zone and farfield zone patch lists contain"rotorDisk-bet_disk"(not"slidingInterface-bet_disk").Test Plan
test_custom_volume_with_rotor_disk_cylinderpassestest_farfield_enclosed_entities_unwraps_custom_volume_with_cylinderstill passes (this test usesRotationVolume, notAxisymmetricRefinement, so the cylinder correctly remains"slidingInterface-")test_volume_meshing_translatortests pass unchangedNote
Low Risk
Low risk: narrowly forwards existing
rotor_disk_namesinto zone patch-name translation and adds a focused regression test; main impact is patch naming in translated meshing JSON for cylinders used as rotor disks.Overview
Fixes volume-meshing translation so cylinders that are rotor disks (from
AxisymmetricRefinement) are named with therotorDisk-prefix not only in sliding-interfaceenclosedObjects, but also when referenced insideCustomVolume.bounding_entitiesand farfieldenclosed_entities.This threads
rotor_disk_namesthrough_get_custom_volumesand_build_farfield_zoneto_translate_enclosed_entity_name, and adds a regression test asserting both the custom zone and generatedfarfieldzone emitrotorDisk-<name>patches (and notslidingInterface-<name>).Reviewed by Cursor Bugbot for commit edc8bdb. Bugbot is set up for automated code reviews on this repo. Configure here.