[Hotfix 25.9]: [FXC-7485] Bypass PorousJump interface check for farfield/CV overlapping face pairs#2030
Closed
benflexcompute wants to merge 1 commit intorelease-candidate/25.9from
Conversation
…eld/CV overlapping face pairs Why: PorousJump validation rejected pairs where one surface was only in farfield enclosed_entities and the other only in some CustomVolume bounding_entities. Such pairs represent two distinct geometry faces that the mesher merges into an interface, so they should be allowed. The existing _is_farfield_custom_volume_interface helper only handled the case where a single dual-belonging face is referenced on both sides; it did not cover the more typical scenario of two overlapping faces, each exclusive to its zone. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing — branch was named with wrong prefix (bzhao/... instead of BenY/...). Reopening from BenY/FXC-7485-porousjump-farfield-cv-interface. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entity_pairspair spans two overlapping geometry faces, one only inAutomatedFarfield.enclosed_entitiesand the other only in aCustomVolume.bounding_entities. The mesher merges them into an interface, so the pair is valid input._is_farfield_custom_volume_interfacehelper only handled a different (and rarer) case: a single face referenced in both sides via dual-belonging. The new_is_farfield_to_custom_volume_pairhelper is added alongside it and the two cases are kept conceptually separate, each with its own docstring explaining the meshing behavior it corresponds to.Failing case before this fix
PorousJump(entity_pairs=[(Intake, inside5)], ...)where:Intakeis only in farfieldenclosed_entitiesinside5is only in CustomVolumebounding_entitiesprivate_attribute_is_interface=nullat the params/validation stagePreviously failed with
Boundary 'Intake' is not an interface. Now passes.Test plan
test_porousJump_farfield_to_custom_volume_paircovering both pair orderings + a negative case (two farfield-only surfaces)test_porousJump_cross_custom_volume_interfaceandtest_porousJump_farfield_custom_volume_interfacestill pass (negative cases still raise as expected)tests/simulation/params/test_validators_params.py(63 tests) passes locally🤖 Generated with Claude Code
Note
Medium Risk
Touches validation logic for
PorousJumpinterface pairing, which can change which configs are accepted/rejected and could mask genuinely invalid surface pairs if the farfield/CV membership sets are wrong. Scope is small and covered by a targeted unit test, keeping risk contained.Overview
PorousJumpvalidation now skips the “must be interface” check for an additional meshing case: anentity_pairspair where one surface ID appears only in farfieldenclosed_entitiesand the other appears only in aCustomVolume’sboundary_surface_ids(the mesher later merges them into an interface).This is implemented via a new helper (
_is_farfield_to_custom_volume_pair) alongside the existing dual-belonging-face bypass, and is covered by a new unit test that exercises both pair orderings plus a negative case (two farfield-only surfaces still error).Reviewed by Cursor Bugbot for commit 12110bc. Bugbot is set up for automated code reviews on this repo. Configure here.