feat(client): re-export VoxelGrid for direct volume rendering#2038
Closed
andrzej-krupka wants to merge 1 commit intomainfrom
Closed
feat(client): re-export VoxelGrid for direct volume rendering#2038andrzej-krupka wants to merge 1 commit intomainfrom
andrzej-krupka wants to merge 1 commit intomainfrom
Conversation
andrzej-krupka
force-pushed
the
andrzej/voxel-grid-schema
branch
2 times, most recently
from
5d2c59e to
3f436bf
Compare
Mirrors the schema-side VoxelGrid addition (flexcompute/flex VoxelGrid PR) so client code can do `fl.VoxelGrid(center=..., size=..., resolution=...)` and pass the entity to `RenderOutputGroup.volumes`. VoxelGrid is a strict-AABB sibling of Box; both extend the new `_BoxRegionBase` on the schema side, so this PR is purely a re-export addition (primitives relay + public namespace). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
andrzej-krupka
force-pushed
the
andrzej/voxel-grid-schema
branch
from
3f436bf to
aa10770
Compare
Contributor
Author
|
Closing — superseded by flexcompute/compute#5052. The Flow360 client was inlined into the compute repo by flexcompute/compute#4990 / flexcompute/compute#4956. compute is now the canonical home; this repo is a downstream copybara mirror. The 2-file re-export change in this PR is now part of the consolidated compute PR alongside the schema additions. Closing rather than re-targeting because the work moves to a different repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacement for closed #2026. Pairs with the new flex VoxelGrid PR (flexcompute/flex#12290).
VoxelGridto the primitives relay (flow360/component/simulation/primitives.py).VoxelGridtoflow360._public_namespaceimport +__all__sofl.VoxelGridis reachable from the top level.VoxelGridis a strict-AABB sibling ofBox; both extend the new_BoxRegionBaseon the schema side, so this PR is purely re-export plumbing.CI status
code-style/{black,isort,lint,json-key-order}andAnalyze (python)pass.The
testmatrix will fail withImportError: cannot import name 'VoxelGrid' from 'flow360_schema.models.entities.volume_entities'until flex#12290 lands and a new flow360_schema package is published —VoxelGriddoesn't exist in the published schema dep yet. CI will turn green automatically once the schema dep ships. The pylint disable on the new import is gated on the same publication.Paired PRs
from flow360.component.simulation.primitives import VoxelGridin its translator test; submodule pointer already bumped to this branch's head.Test plan
from flow360 import VoxelGridworksfl.VoxelGrid(...)through afl.RenderOutputGroup(volumes=[...])🤖 Generated with Claude Code