Skip to content

fix: raise error when _finalized simulation fails #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix: raise error when _finalized simulation fails #2913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_components/test_source_frames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,5 @@ def test_source_absorber_frames():
)
],
)
with pytest.raises(pydantic.ValidationError):
_ = bad_sim._finalized
with pytest.raises(td.exceptions.Tidy3dError):
_ = bad_sim._validate_finalized()
6 changes: 3 additions & 3 deletions tidy3d/components/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,11 +2227,11 @@ def _validate_finalized(self):

try:
_ = self._finalized
except Exception:
log.error(
except Exception as e:
raise Tidy3dError(
"Simulation fails after requested mode source PEC frames are added. "
"Please inspect '._finalized'."
)
) from e


class Simulation(AbstractYeeGridSimulation):
Expand Down